Skip to content

Fix empty NavDisplay backstack by removing redundant onBack calls #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rteyssandier merged 2 commits into from
May 12, 2026
Merged

Fix empty NavDisplay backstack by removing redundant onBack calls #523

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e260f63
Fix empty NavDisplay backstack by removing redundant onBack calls in …
mikef-dk May 8, 2026
62d8b75
Remove onDismissRequest from FloconPanel EscapeHandler
mikef-dk May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ...mmonMain/kotlin/io/github/openflocon/library/designsystem/components/panel/FloconPanel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,6 @@ fun FloconPanel(
EscapeHandler {
coroutineScope.launch {
state.hide()
onDismissRequest()
}
true
}
Expand Down
2 changes: 0 additions & 2 deletions ...ktop/navigation/src/commonMain/kotlin/io/github/openflocon/navigation/scene/PanelScene.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ data class PanelScene(
onClick = {
scope.launch {
state.hide()
onBack()
}
},
Comment thread
mikef-dk marked this conversation as resolved.
modifier = Modifier
Expand All @@ -70,7 +69,6 @@ data class PanelScene(
scope.launch {
onPin.onPin()
state.hide()
onBack()
}
},
modifier = Modifier
Expand Down