Skip to content

Update build secrets blog post #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
welteki wants to merge 1 commit into
base: master
Choose a base branch
from

Update build secrets blog post

4a559b3
Select commit
Loading
Failed to load commit list.
Open

Update build secrets blog post #358

Update build secrets blog post
4a559b3
Select commit
Loading
Failed to load commit list.
reviewfn / succeeded Apr 2, 2026 in 42s

AI Code Review Results

AI Pull Request Overview

Summary

  • Updated blog post on encrypted build secrets to remove support for literal values in build_secrets
  • Changed examples to use file paths instead of inline values
  • Replaced faas-cli pro build references with faas-cli build
  • Updated documentation link anchor from #plugins-and-build-time-secrets to #build-time-secrets
  • Added instructions for creating secret files before referencing them in stack.yaml
  • Modified wrapping up section to remove pro build reference

Approval rating (1-10)

9

Summary per file

Summary per file
File path Summary
_posts/2026-03-24-encrypted-build-secrets.md Updated examples to use file paths for build_secrets, removed literal value support

Overall Assessment

The changes appropriately update the documentation to reflect that build_secrets in stack.yaml no longer accepts literal values and must use file paths. The command references have been updated from faas-cli pro build to faas-cli build. No technical inaccuracies or security risks identified in the updated content.

Detailed Review

Detailed Review

_posts/2026-03-24-encrypted-build-secrets.md

  • The change from literal build_secrets values to file paths aligns with the stated API changes and improves security by avoiding plaintext secrets in configuration files.
  • Added file creation steps (mkdir -p .secrets and echo -n commands) provide clear guidance for users, reducing potential configuration errors.
  • Command reference updates from faas-cli pro build to faas-cli build appear consistent with current CLI naming.
  • Link anchor update to #build-time-secrets should be verified against the actual documentation to ensure it resolves correctly.
  • No issues with the sealed secret examples or CI pipeline instructions.
  • Risk: If the documentation link does not exist or the anchor is incorrect, users following the tutorial may encounter broken navigation. Recommend testing the link in the live docs.

AI agent details.

Agent processing time: 26.484s
Environment preparation time: 6.1s
Total time from webhook: 47.463s
View more details on reviewfn