Fix gulp build deprecated warning

[sjpadgett]

• move and modify @ttskch/select2-bootstrap4-theme/src/select2-bootstrap4 to public/modified
• remove package @ttskch/select2-bootstrap4-theme/src/select2-bootstrap4

Fixes #6542

Short description of what this resolves:

May be a better way but this was pretty straight forward. Let me know if have a different idea.

[sjpadgett]

Full install and build < 3 minutes. We can consolidate and improve this I'm sure.

[stephenwaite]

thought you'd get schmancy with

edit: where #6524 was headed

[sjpadgett]

The only issue are two calc in select2 bs4 upstream so just needed to own the theme. There are no other upstream issues.
If I understand what you are asking....

[stephenwaite]

another approach might be run the division sass migrator command after importing but before building if understanding how it works

[sjpadgett]

I’m not sure Stephen. It’s only that select two bootstrap for sass that’s at issue. We could bring in another theme however we’d have to modify gulp to compile.
This was just the quickest and easiest way without having to re-factor a bunch of code.
Although I’m not married to this

[bradymiller]

Since it looks like upstream will never fix this (last commit in that repo in 2021 and there is even a PR that has been submitted to fix this a long time ago :) ttskch/select2-bootstrap4-theme#77 ). So seems like simplest thing is to take it over and do what @sjpadgett did (less moving pieces than fixing on fly since this will never be fixed anyways :)).

[stephenwaite]

[macomeza]

Great job!