Skip to content

Added sepolicy for adb service#1029

Open
GargiQcom wants to merge 1 commit intoopenembedded:masterfrom
GargiQcom:master
Open

Added sepolicy for adb service#1029
GargiQcom wants to merge 1 commit intoopenembedded:masterfrom
GargiQcom:master

Conversation

@GargiQcom
Copy link

  • Labeled adb binary
  • Moved adb shell from initrc_t to unconfined_t

meta-selinux doesn't provide adb domain, changes are qualcomm specific: SELinuxProject/refpolicy#1085

@OldManYellsAtCloud
Copy link
Contributor

Please prefix the commit summary with the recipe name you are modifying.

I think it would be useful to mention in the commit message also why it is added to meta-oe instead of meta-selinux.

@GargiQcom
Copy link
Author

Updated the commit message.
We are adding the changes here as adb service is a part of meta-oe and refpolicy in meta-selinux does not provide adb domain: SELinuxProject/refpolicy#1085

@OldManYellsAtCloud
Copy link
Contributor

meta-openembedded is the layer name - the recipe name here would be repolicy-targeted. Regarding the reason, can you also include in the commit message? This conversation on the PR is only present in Github, and it will not be visible on other mirrors - but the commit message will make it clear to everyone what happened.

- Labeled adb binary
- Moved adb shell from initrc_t to unconfined_t
- meta-selinux does not provide adb domain
  added policy in meta-oe instead of refpolicy:
  SELinuxProject/refpolicy#1085

Upstream-Status: Inappropriate [meta-oe Specific]

Signed-off-by: Gargi Misra <gmisra@qti.qualcomm.com>
@GargiQcom
Copy link
Author

Updated the commit text with recipe name and reason for adding in meta-openembedded instead of refpolicy.

@GargiQcom
Copy link
Author

Hi @OldManYellsAtCloud
Could you please help in reviewing the changes ?

@OldManYellsAtCloud
Copy link
Contributor

From my end it's okay, thanks. Khem is a bit preoccupied now outside of the project, but should be back soon to take care of the final steps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants