fix!: Unify default for compiling vs serving themes#68
Draft
kdmccormick wants to merge 1 commit into
Draft
Conversation
Before, the effectively defaults were: * Compile nothing (`[]`) * Serve just the light theme (`['light']`) which made the `PARAGON_ENABLED_THEMES` setting somewhat confusing. This changes the default to `['light']` for both. BREAKING CHANGE: Running `tutor paragon-build-tokens` with default settings will now compile the light theme. Before, it would compile nothing. As before, tutor-contrib-paragon still serves just the light theme by default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Context: #67 (comment)
I haven't tested this yet. Honestly I haven't thought hard about whether it's the right fix or not. Just wanted to open this to start the discussion and keep track of the discrepancy.
Description
Before, the effective defaults were:
[])['light'])which made the
PARAGON_ENABLED_THEMESsetting somewhat confusing.This changes the default to
['light']for both.BREAKING CHANGE: Running
tutor paragon-build-tokenswith default settings will now compile the light theme. Before, it would compile nothing. As before, tutor-contrib-paragon still serves just the light theme by default.AI use
None