fix: casting issues with grading policy#38631
Open
nsprenkle wants to merge 2 commits into
Open
Conversation
Fixes an issue with some courses causing the progress page to crash
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes issues where incorrectly typed grading policies caused breakages on the progress page.
Supporting information
Some courses were running into the error below which was a result of a grading policy using strings instead of numbers for their values.
This fix is to correctly cast
ints andfloats represented as either as strings or numerics to the correct data types to fix this issue.Testing instructions
500server error.Deadline
ASAP - actively causes breakages in some courses.