fix: retirement PII leaks by redacting pending secondary email/name data#38427
Open
ktyagiapphelix2u wants to merge 6 commits into
Open
fix: retirement PII leaks by redacting pending secondary email/name data#38427ktyagiapphelix2u wants to merge 6 commits into
ktyagiapphelix2u wants to merge 6 commits into
Conversation
robrap
reviewed
Apr 24, 2026
Contributor
robrap
left a comment
robrap
left a comment
There was a problem hiding this comment.
Thanks. Some comments to get started...
| .. pii: Contains new_secondary_email, not currently retired | ||
| .. pii: Contains new_secondary_email, redacted in `DeactivateLogoutView` | ||
| .. pii_types: email_address | ||
| .. pii_retirement: retained |
Contributor
There was a problem hiding this comment.
@bmedx: [inform] This doesn't seem like it would have been intentionally retained, so I'm fine with calling this a bug and just fixing. Any objections?
Contributor
There was a problem hiding this comment.
@ktyagiapphelix2u: Did you follow up on this in Slack?
Contributor
Author
There was a problem hiding this comment.
Apologies, this slipped my mind. I'm taking care of it now.
Akanshu-2u
reviewed
Apr 28, 2026
Akanshu-2u
reviewed
Apr 28, 2026
Akanshu-2u
reviewed
Apr 28, 2026
Akanshu-2u
reviewed
Apr 28, 2026
Akanshu-2u
reviewed
Apr 28, 2026
robrap
reviewed
Apr 29, 2026
Contributor
robrap
left a comment
robrap
left a comment
There was a problem hiding this comment.
@ktyagiapphelix2u: I added some top-level comments before starting this review. Please respond to those as well. Thank you.
ktyagiapphelix2u
force-pushed
the
ktyagi/secondaryemail
branch
from
84d0cf9 to
6320d0b
Compare
ttak-apphelix
approved these changes
May 12, 2026
ktyagiapphelix2u
force-pushed
the
ktyagi/secondaryemail
branch
from
db74adc to
a14e9a1
Compare
ktyagiapphelix2u
force-pushed
the
ktyagi/secondaryemail
branch
from
a14e9a1 to
d7a28df
Compare
ttak-apphelix
approved these changes
Jun 2, 2026
ktyagiapphelix2u
commented
Jun 2, 2026
robrap
reviewed
Jun 2, 2026
robrap
reviewed
Jun 2, 2026
robrap
reviewed
Jun 2, 2026
ktyagiapphelix2u
force-pushed
the
ktyagi/secondaryemail
branch
from
f214c6c to
a2ce50a
Compare
ktyagiapphelix2u
force-pushed
the
ktyagi/secondaryemail
branch
from
d1687f6 to
11561c4
Compare
robrap
reviewed
Jun 3, 2026
Contributor
robrap
left a comment
robrap
left a comment
There was a problem hiding this comment.
Can you fix the pylint issues and then we can merge? Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates user retirement and secondary email cleanup flows to redact sensitive secondary email data before deletion.
Changes
Added redaction + delete flow for PendingSecondaryEmailChange
Updated AccountRecovery.retire_recovery_email to redact before delete
Integrated cleanup into retirement/deactivation flows and management commands
Added tests verifying UPDATE occurs before DELETE
Ticket & Reference
https://2u-internal.atlassian.net/browse/BOMS-499