docs: cbe competency rule profile adr amendments#636
Conversation
|
Thanks for the pull request, @mgwozdz-unicon! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Claude assisted...
Summary
Amends ADR 0002 (competency criteria model) and ADR 0003 (versioning) to close gaps in the
CompetencyRuleProfiledesign in this Slack thread: https://openedx.slack.com/archives/C09A1BN1CSE/p1783010474048009Changes
ADR 0002
CompetencyRuleProfilescope fields (organization_id,course_id,competency_taxonomy_id) are now consistently nullable, at most one populated per row; combining more than one on a single profile is explicitly out of scope for now (documented as a new Rejected Alternative, since a required-parent-scope hierarchy was considered and doesn't fit taxonomies that span multiple organizations).CompetencyTaxonomy.taxonomy_overrides_org, a boolean (defaultfalse) that breaks the tie when both an organization-scoped and a taxonomy-scoped profile could apply to the same criterion.CompetencyCriterion.competency_rule_profile_idgets assigned: it's recomputed at several explicit trigger points (creation, a more specific profile appearing later, a per-criterion override being set, an override being cleared back to the default) rather than resolved dynamically at evaluation time. Added the resolution-order tables (by which profile rows exist) and the org/taxonomy tiebreak table directly to the ADR.CompetencyRuleProfileis now never hard-deleted, even pre-use (a carve-out from the general delete-protection rule) — retirement is archive-only via a newarchivedcolumn. Editing is restricted torule_type/rule_payload; scope fields are immutable after creation.Graderule payload example to the platform's actual fractional grade scale (0.0–1.0, not 0–100), and specified the allowedopvalues (gte,lte,eq).ADR 0003
CompetencyRuleProfileexplicitly, and extends the existing edit-warning requirement to cover profile reassignment and override-state switching, not just direct edits.