chore: update test-site to use autoinstall from @openedx/frontend-dev-utils#175
Open
brian-smith-tcril wants to merge 3 commits intoopenedx:mainfrom
Open
chore: update test-site to use autoinstall from @openedx/frontend-dev-utils#175brian-smith-tcril wants to merge 3 commits intoopenedx:mainfrom
brian-smith-tcril wants to merge 3 commits intoopenedx:mainfrom
Conversation
The lock file was last updated at e7d135b against @openedx/frontend-base@1.0.0-alpha.12. Four commits have since landed including the alpha.13 release, so regenerate the lock to reflect the current tarball. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replace the local copy of autoinstall tooling in test-site/tools/autoinstall with the published @openedx/frontend-dev-utils package. Updates the dev:autoinstall script to use the devutils-dev-with-autoinstall bin. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #160
Removes the local copy of autoinstall tooling from
test-site/tools/autoinstall/and replaces it with the published@openedx/frontend-dev-utilspackage.Changes
test-site/package.json: updatedev:autoinstallscript to usedevutils-dev-with-autoinstallbin withPORT=8080andFRONTEND_BASE_DIR=..test-site/package.json: add@openedx/frontend-dev-utils@^1.0.0as a devDep, removechokidaras a direct devDep (now a transitive dep via@openedx/frontend-dev-utils)test-site/tools/autoinstall/README.mdto link to the@openedx/frontend-dev-utilsautoinstall docsWork log
Issue #160: Update test-site to use autoinstall from frontend-dev-utils
#160
Context
The
test-siteinfrontend-basehad a local copy of autoinstall tooling intest-site/tools/autoinstall/. That code has since been extracted and publishedas
@openedx/frontend-dev-utils@1.0.0. The goal is to remove the local copy anduse the published package instead.
The blocking issue (publishing the package) is closed:
openedx/frontend-dev-utils#4
Key findings
devutils-dev-with-autoinstallbinenv.mjsdiffers from the local one in two ways:FRONTEND_BASE_DIRis now configurable via env var (defaults to../frontend-base)PORTis now required via env var (throws if not set)dev:autoinstallscript needs to passPORT=8080andFRONTEND_BASE_DIR=..explicitlychokidarwas a direct devDep of test-site; it's now a dep of frontend-dev-utils so can be removedChanges
Commit 1: update test-site package-lock.json
npm run prepack && npm run pack)test-site/package-lock.json(tarball hash had drifted from what was committed)Commit 2: use @openedx/frontend-dev-utils for autoinstall
test-site/package.json: updatedev:autoinstallscript toPORT=8080 FRONTEND_BASE_DIR=.. devutils-dev-with-autoinstalltest-site/package.json: add@openedx/frontend-dev-utils@^1.0.0, removechokidaras direct devDeptest-site/tools/autoinstall/(all 4 files)test-site/package-lock.jsonInvestigation: webpack-cli peer:true
While working on commit 2, noticed
peer: truewas dropping offwebpack-cliin thelock file diff. Investigated whether it was caused by the chokidar → frontend-dev-utils
swap. Confirmed it is NOT — a fresh regen with the original deps (no stash popped) also
drops
peer: trueand bumps axios 0.30.2 → 0.30.3. Pure npm nondeterminism between runs.Resolution: amended commit 1 to include the fresh regen (capturing the webpack-cli and
axios noise there), so commit 2's diff is clean and only shows frontend-dev-utils changes.
Status
autoinstall-from-dev-utilschore: update test-site package-lock.json to alpha.13(amended to absorb nondeterminism)chore: use @openedx/frontend-dev-utils for autoinstall in test-siteFRONTEND_BASE_DIR=..in the script — published env.mjs defaults to../frontend-basewhich doubles the path since test-site lives inside frontend-base, not alongside it
docs: update README to reference @openedx/frontend-dev-utils autoinstall