Introduce courseNavigationBar on header slot#106
Introduce courseNavigationBar on header slot#106diana-villalvazo-wgu wants to merge 6 commits intoopenedx:mainfrom
Conversation
|
Thanks for the pull request, @diana-villalvazo-wgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
114be5d to
a79f6cf
Compare
a79f6cf to
45c11fe
Compare
e883f25 to
4536f10
Compare
4536f10 to
26b19ea
Compare
|
@arbrandes do you remember which FWG meeting we discussed this in? I think I need to look through our discussion to remember how the "render conditionally based on role" part is supposed to work (IIRC we talked about apps having roles associated?) |
we discussed it on this one https://openedx.atlassian.net/wiki/spaces/COMM/pages/5255593985/2025-10-09+Frontend+Working+Group+Meeting+Notes+Shai-Hulud+Program+Dashboard+etc For now i didn't introduce anything related to roles and just abstract how is working now (retrieving the enabled tabs from the course-metadata endpoint) |
|
Friendly ping on this, @brian-smith-tcril @arbrandes |
arbrandes
left a comment
There was a problem hiding this comment.
Looks good! I do have some questions and comments, but I think this would work, architecturally speaking. I know we discussed having a way to dynamically assign roles, but we can cross that bridge when we get there.
(Also, sorry it took a while to get here.)
| <div className="nav-menu"> | ||
| <Tabs className="nav-underline-tabs" aria-label={intl.formatMessage(messages.courseMaterial)} onSelect={handleSelectedTab}> | ||
| {tabs.map(({ title, slug }) => ( | ||
| <Tab eventKey={slug} title={title} key={slug} /> |
There was a problem hiding this comment.
I think we might want to use activeKey too, here, no? To give the user indication of which one is active.
|
I also just realized that openedx/frontend-app-instruct#32 is not doing the same thing. It's solving a similar problem, though, so we should keep both implementations in sync where it makes sense. |
| const courseId = extractCourseId(location.pathname); | ||
|
|
||
| const { data } = useQuery({ | ||
| queryKey: ['org.openedx.frontend.app.header.course-meta', courseId], |
There was a problem hiding this comment.
shouldn't this base ID be a constant?
26b19ea to
5681171
Compare
I think it got out of sync because there was extra work that was done in instruct after the decision of just migrating this ones as they were I would say that it makes sense if we wrap this one up with the current changes and as inmediate followup we do the update so this one is more in sync with instruct dash, what do you think @arbrandes ? |
arbrandes
left a comment
There was a problem hiding this comment.
@diana-villalvazo-wgu, mind addressing the unresolved comments? Thanks!
a6124e6 to
7e13eb9
Compare
df88abc to
dbaed01
Compare
arbrandes
left a comment
There was a problem hiding this comment.
A few more questions and suggestions, if you don't mind. Thanks!
| activeKey={currentTab} | ||
| > | ||
| { | ||
| tabs.map((tab: { tabId: string, url: string, title: string }) => ( |
There was a problem hiding this comment.
tabId doesn't actually exist, here. It's normalized out in service.ts. It would be best to create an actual type for a tab, so that Typescript would catch the issue for us.
| <Nav.Link | ||
| href={tab.url} | ||
| active={tab.tabId === currentTab} | ||
| onClick={() => setCurrentTab(tab.tabId)} |
There was a problem hiding this comment.
This is the only place setCurrentTab is called. This is not going to survive navigation because we're using an href={tab.url} for each tab. The current tab should be derived fromlocation.pathname (or equivalent).
On the other hand, shouldn't we have a way to navigate() to tabs to avoid the full page reload, when possible?
22e4e37 to
1638f0a
Compare
1638f0a to
3999521
Compare
Description
As part of the conversion of MFEs to frontend base, we figured it out that 3 different repos will need Course Navigation Bar (Learning, Discussions and Instructor), so instead of having repetitive code on 3 different repos we come up with the following approach:
Screenshot