Skip to content

refactor: identify table filters by column id instead of localized label#168

Draft
dcoa wants to merge 1 commit into
openedx:masterfrom
eduNEXT:dcoa/filters-id
Draft

refactor: identify table filters by column id instead of localized label#168
dcoa wants to merge 1 commit into
openedx:masterfrom
eduNEXT:dcoa/filters-id

Conversation

@dcoa

@dcoa dcoa commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Summary

Refactors the table-filter components so a filter group is keyed by its column id (a stable identifier) rather than by deriving an id from the localized button label. This removes the FILTER_GROUP_TO_ID translation map and the fragile filterButtonText.toLowerCase() derivation.

What & why

  • New filterId prop on MultipleChoiceFilter : the column id, used both for chip grouping and for removing an applied filter. Previously the group key was inferred from the human-readable label.
  • TableControlBar now passes filterId={column.id || column.accessor} to each filter and uses it directly in handleCloseFilter; the FILTER_GROUP_TO_ID map is gone, and FILTER_CHIPS_ICONS is keyed by column id.
  • OrgFilter / RolesFilter / ScopesFilter / ScopeFilterBar forward filterId through.
  • ScopesFilter uses the shared getScopeContextType() helper instead of an inline externalKey.startsWith('lib') check.
  • Minor cleanups on the touched components: memoized the grouped-choice computation, typed previously-implicit any params (handleClickCheckbox, handleSetFilters, group icon), and widened SearchFilter's setFilter signature to string | undefined.

Depends on:

ScopesFilter consumes getScopeContextType/ContextType, which are introduced in #164

Test will fail until dependency is merged

AI use acknowledgement

Supported by Claude Code

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Jun 25, 2026
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @dcoa!

This repository is currently maintained by @openedx/committers-frontend.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Update the status of your PR

Your PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Jun 25, 2026
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Waiting on Author

Development

Successfully merging this pull request may close these issues.

3 participants