refactor: identify table filters by column id instead of localized label#168
refactor: identify table filters by column id instead of localized label#168dcoa wants to merge 1 commit into
Conversation
|
Thanks for the pull request, @dcoa! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Update the status of your PRYour PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Summary
Refactors the table-filter components so a filter group is keyed by its column id (a stable identifier) rather than by deriving an id from the localized button label. This removes the
FILTER_GROUP_TO_IDtranslation map and the fragilefilterButtonText.toLowerCase()derivation.What & why
filterIdprop onMultipleChoiceFilter: the column id, used both for chip grouping and for removing an applied filter. Previously the group key was inferred from the human-readable label.ilterId={column.id || column.accessor}to each filter and uses it directly in handleCloseFilter; the FILTER_GROUP_TO_ID map is gone, and FILTER_CHIPS_ICONS is keyed by column id.filterIdthrough.getScopeContextType()helper instead of an inlineexternalKey.startsWith('lib')check.setFiltersignature tostring | undefined.Depends on:
ScopesFilterconsumesgetScopeContextType/ContextType, which are introduced in #164Test will fail until dependency is merged
AI use acknowledgement
Supported by Claude Code