Skip to content

fixed component name for mapper implementation in api-project-v1 #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Joselee2908 wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fixed component name for mapper implementation in api-project-v1 #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e50b3a2
fixed component name for mapper implementation in api-project-v1
Joselee2908 Jul 23, 2026
ec03138
refactor: rename ProjectMapper to ProjectMapperV1 and update references
Joselee2908 Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...1/src/main/java/org/opendevstack/apiservice/projectv1/facade/impl/ProjectsFacadeImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
import org.opendevstack.apiservice.projectv1.exception.PageNotFoundException;
import org.opendevstack.apiservice.projectv1.facade.ProjectsFacade;
import org.opendevstack.apiservice.projectv1.client.model.GetProjectsResponse;
import org.opendevstack.apiservice.projectv1.mapper.ProjectMapper;
import org.opendevstack.apiservice.projectv1.mapper.ProjectMapperV1;
import org.opendevstack.apiservice.serviceproject.model.ProjectSummary;
import org.opendevstack.apiservice.serviceproject.service.ProjectService;
import org.springframework.data.domain.Page;
Expand All @@ -26,7 +26,7 @@ public class ProjectsFacadeImpl implements ProjectsFacade {

private final ProjectService projectService;

private final ProjectMapper projectMapper;
private final ProjectMapperV1 projectMapper;

@Override
public GetProjectsResponse getProjects(Integer page, Integer size) {
Expand Down
4 changes: 1 addition & 3 deletions ...rvice/projectv1/mapper/ProjectMapper.java → ...ice/projectv1/mapper/ProjectMapperV1.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,13 @@
import org.opendevstack.apiservice.projectv1.client.model.ProjectsResponse;
import org.opendevstack.apiservice.serviceproject.model.ProjectSummary;
import org.opendevstack.apiservice.serviceproject.model.Status;
import org.springframework.stereotype.Component;

import java.time.OffsetDateTime;
import java.time.format.DateTimeFormatter;
import java.util.List;

@Mapper(componentModel = "spring")
@Component("projectMapperV1")
public interface ProjectMapper {
public interface ProjectMapperV1 {

DateTimeFormatter FORMATTER = DateTimeFormatter.ISO_OFFSET_DATE_TIME;

Expand Down
4 changes: 2 additions & 2 deletions ...c/test/java/org/opendevstack/apiservice/projectv1/facade/impl/ProjectsFacadeImplTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import org.opendevstack.apiservice.projectv1.client.model.GetProjectsResponse;
import org.opendevstack.apiservice.projectv1.client.model.ProjectsResponse;
import org.opendevstack.apiservice.projectv1.exception.PageNotFoundException;
import org.opendevstack.apiservice.projectv1.mapper.ProjectMapper;
import org.opendevstack.apiservice.projectv1.mapper.ProjectMapperV1;
import org.opendevstack.apiservice.serviceproject.model.ProjectSummary;
import org.opendevstack.apiservice.serviceproject.model.Status;
import org.opendevstack.apiservice.serviceproject.service.ProjectService;
Expand All @@ -29,7 +29,7 @@ class ProjectsFacadeImplTest {
private ProjectService projectService;

@Mock
private ProjectMapper projectMapper;
private ProjectMapperV1 projectMapper;

private ProjectsFacadeImpl sut;

Expand Down
6 changes: 3 additions & 3 deletions ...e/projectv1/mapper/ProjectMapperTest.java → ...projectv1/mapper/ProjectMapperV1Test.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,13 @@

import static org.assertj.core.api.Assertions.assertThat;

class ProjectMapperTest {
class ProjectMapperV1Test {

private ProjectMapper projectMapper;
private ProjectMapperV1 projectMapper;

@BeforeEach
void setUp() {
projectMapper = Mappers.getMapper(ProjectMapper.class);
projectMapper = Mappers.getMapper(ProjectMapperV1.class);
}

@Test
Expand Down
Loading