Skip to content

Comments

Cleaning up#425

Merged
agarny merged 6 commits intoopencor:mainfrom
agarny:cleaning-up
Feb 24, 2026
Merged

Cleaning up#425
agarny merged 6 commits intoopencor:mainfrom
agarny:cleaning-up

Conversation

@agarny
Copy link
Contributor

@agarny agarny commented Feb 24, 2026

No description provided.

Copilot AI review requested due to automatic review settings February 24, 2026 02:55
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request focuses on code cleanup and refactoring across multiple Vue components in the renderer. The changes primarily standardize naming conventions for template refs, remove unused code, and consolidate toast notification handling.

Changes:

  • Standardized template ref naming with Ref suffix (e.g., mainDivmainDivRef, contextMenucontextMenuRef)
  • Introduced centralized addToast helper function for consistent toast notifications
  • Removed dynamic ID generation and unused interface exports

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
GraphPanelWidget.vue Renamed template refs mainDiv to mainDivRef and contextMenu to contextMenuRef
SimulationExperimentView.vue Renamed template refs, removed ID customization, changed simulationOnly prop to required, refactored toolbar visibility logic, fixed typo, conditionally rendered center toolbar section
SimulationExperimentViewSettingsDialog.vue Renamed popover refs to use Ref suffix, added Popover import
OpenCOR.vue Renamed template refs, introduced addToast helper, removed ID customization logic, reorganized imports, added defensive check for toast element
MainMenu.vue Renamed menuBar to menuBarRef, fixed duplicate word "clicking" in comment
ContentsComponent.vue Removed unused IContentsComponent interface export, removed ID customization, changed simulationOnly prop to required
package.json, src/renderer/package.json Bumped version from 0.20260224.0 to 0.20260224.1

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@agarny agarny merged commit 02872f3 into opencor:main Feb 24, 2026
12 checks passed
@agarny agarny deleted the cleaning-up branch February 24, 2026 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant