Fix blocking messages and dialogs centering#421
Conversation
|
Thanks a lot @akhuoa, I can confirm that it all works as I would expect! I wish I had thought of it! However, I am not keen on hard-coded values. I mean, if I "manually" (e.g., in DevTools) change the font size for the menu bar then blocking messages and dialogs won't be vertically centered anymore. So, whatever solution is used needs to be reactive to the height of the menu bar. I know how to do that (see 9dbc15f for instance). I am happy to do it unless you want to give a try. If so then on top of doing this, please:
|
a594dfd to
f66181f
Compare
Hi @agarny, thanks for the feedback.
|
c591167 to
b36f11e
Compare
|
Thanks a lot @akhuoa. I have just pushed some minor cleaning up and I am going to merge your changes in once CI is complete. |
This PR fixes issue #420.
I've added a
padding-topvalue to the dialog backdrop container using the main menu's height, so it won't affect the dialog's dragging behaviour. For the blocking messages, I've added half the main menu's height to theirmargin-topsince the blocks use the translate property. These modifications apply only when it has a main menu.I've tested it on both web app and desktop app.