When mcs are exhausted, uniqMcs should return an error#248
Open
zzzzzzzzzy9 wants to merge 1 commit intoopencontainers:mainfrom
Open
When mcs are exhausted, uniqMcs should return an error#248zzzzzzzzzy9 wants to merge 1 commit intoopencontainers:mainfrom
zzzzzzzzzy9 wants to merge 1 commit intoopencontainers:mainfrom
Conversation
Signed-off-by: zzzzzzzzzy9 <zhang.yu58@zte.com.cn>
zzzzzzzzzy9
requested review from
cyphar,
kolyshkin,
mrunalp,
rhatdan,
runcom and
thaJeztah
as code owners
Author
Author
kolyshkin
requested changes
Dec 4, 2025
Collaborator
kolyshkin
left a comment
kolyshkin
left a comment
There was a problem hiding this comment.
NACK. You change the public API in an incompatible way, it is not acceptable
Collaborator
The acceptable way is:
|
Collaborator
|
@zzzzzzzzzy9 are you still interested in adding a new API? |
Collaborator
|
I guess we should come up with the new API and deprecate the old one; then remove the old one ~1 year later. |
Collaborator
|
Needs a rebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There should be an exit branch in the infinite loop in the code, and return error should be inside the for loop.
Additionally, when judging the length of mcsList, the delete method of mcs should directly remove the key-value pair instead of setting the key-value pair to false, otherwise the length of mcsList will keep increasing.