libct/cg: skip hidden ones when parsing cgroup mounts#3890
Closed
liusdu wants to merge 1 commit intoopencontainers:mainfrom
Closed
libct/cg: skip hidden ones when parsing cgroup mounts#3890liusdu wants to merge 1 commit intoopencontainers:mainfrom
liusdu wants to merge 1 commit intoopencontainers:mainfrom
Conversation
According to [1], "If a new mount is stacked on top of a previous existing mount, at pathname P, then the parent of the new mount is the previous mount at that location" Use this strategy to skip hidden cgroup mount. 1. https://man7.org/linux/man-pages/man5/proc.5.html Signed-off-by: Liu Hua <weldonliu@tencent.com>
Contributor
|
@liusdu can you create an integration test case, so that we can see the problem the code is trying to solve? |
Member
|
@liusdu I mark this pr as draft. Please rebase, fix the errors, and add some test cases. |
Contributor
|
@liusdu do you plan to keep working on this? |
Contributor
Apparently not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to [1], "If a new mount is stacked on top of a previous existing mount, at pathname P, then the parent of the new mount is the previous mount at that location"
Use this strategy to skip hidden cgroup mount.