Adding AFT-6.3: AFT Prefix Filtering Resilience Test

[keysightgems]

Readme Location: https://github.com/openconfig/featureprofiles/blob/main/feature/afts/filtered_streaming/otg_tests/afts_prefix_filtering_resilience/README.md

One failed out of 3 test cases due to the defect: https://partnerissuetracker.corp.google.com/u/1/issues/517809756

Attached logs here: https://partnerissuetracker.corp.google.com/u/2/issues/517817938

[OpenConfigBot]

Pull Request Functional Test Report for #5522 / 2a0a14d

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		AFT-6.1: AFT Prefix Filtering AFT-6.3: AFT Prefix Filtering Resilience
Cisco 8000E		AFT-6.1: AFT Prefix Filtering AFT-6.3: AFT Prefix Filtering Resilience
Cisco XRd		AFT-6.1: AFT Prefix Filtering AFT-6.3: AFT Prefix Filtering Resilience
Juniper ncPTX		AFT-6.1: AFT Prefix Filtering AFT-6.3: AFT Prefix Filtering Resilience
Nokia SR Linux		AFT-6.1: AFT Prefix Filtering AFT-6.3: AFT Prefix Filtering Resilience
Openconfig Lemming		AFT-6.1: AFT Prefix Filtering AFT-6.3: AFT Prefix Filtering Resilience

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		AFT-6.1: AFT Prefix Filtering AFT-6.3: AFT Prefix Filtering Resilience
Cisco 8808		AFT-6.1: AFT Prefix Filtering AFT-6.3: AFT Prefix Filtering Resilience
Juniper PTX10008		AFT-6.1: AFT Prefix Filtering AFT-6.3: AFT Prefix Filtering Resilience
Nokia 7250 IXR-10e		AFT-6.1: AFT Prefix Filtering AFT-6.3: AFT Prefix Filtering Resilience

Help

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a comprehensive test suite for AFT Prefix Filtering Resilience (AFT-6.3). The new test validates the device's ability to correctly filter AFT entries under various conditions, including device reboots, high-scale route advertisements, and independent filtering policies across different network instances. Supporting changes include platform-specific deviations for Arista and new utilities for configuration management during testing.

Highlights

• New Feature Test Added: A new comprehensive test suite, AFT-6.3: AFT Prefix Filtering Resilience, has been added to validate prefix filtering behavior under various conditions.
• Test Scenarios Covered: The new test includes validation for policy persistence after device reboot, AFT filtering behavior under large-scale route conditions, and independent AFT filtering per network instance.
• Platform Deviation Introduced: A new deviation, AftsGlobalFilterPolicyOCUnsupported, was added to account for platforms (specifically Arista) that do not support OpenConfig paths for AFTs global filter policies.
• DUT Configuration Management Utilities: New utility functions, BackUpConfig and RestoreConfig, were implemented to facilitate saving and restoring DUT configurations, primarily for Arista devices during testing.
• AFT Cache Logic Enhancement: The AFT cache's initial synchronization stopping condition was refined to correctly handle scenarios where no next-hop expectations are provided, allowing prefix validation to proceed independently.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request implements the AFT Prefix Filtering Resilience test (AFT-6.3), adding a new test suite, metadata, backup/restore config helpers, and a deviation for unsupported global filter policies. The review identifies critical bugs in the test implementation: the telemetry validation helpers mustVerifyPrefixEventuallyPresent and mustVerifyPrefixesEventuallyPresent are broken because they poll a static cache without running ListenUntil to process incoming gNMI notifications. Furthermore, the scale policies are never configured on the DUT's routing policy during the scale test, and several policy creation helpers ignore errors from AppendNewStatement, risking nil pointer dereference panics.