Skip to content

PLT-1.1 : Support for breakout configuration and verification for Juniper devices#5519

Open
priyaranjannanda wants to merge 7 commits into
openconfig:mainfrom
priyaranjannanda:PLT-1.1_1
Open

PLT-1.1 : Support for breakout configuration and verification for Juniper devices#5519
priyaranjannanda wants to merge 7 commits into
openconfig:mainfrom
priyaranjannanda:PLT-1.1_1

Conversation

@priyaranjannanda
Copy link
Copy Markdown
Contributor

Added support for breakout configuration and verification for Juniper devices

@priyaranjannanda priyaranjannanda requested a review from a team as a code owner May 28, 2026 16:55
@OpenConfigBot
Copy link
Copy Markdown

OpenConfigBot commented May 28, 2026

Pull Request Functional Test Report for #5519 / 94f0d7e

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
PLT-1.1: Interface breakout Test
Cisco 8000E status
PLT-1.1: Interface breakout Test
Cisco XRd status
PLT-1.1: Interface breakout Test
Juniper ncPTX status
PLT-1.1: Interface breakout Test
Nokia SR Linux status
PLT-1.1: Interface breakout Test
Openconfig Lemming status
PLT-1.1: Interface breakout Test

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
PLT-1.1: Interface breakout Test
Cisco 8808 status
PLT-1.1: Interface breakout Test
Juniper PTX10008 status
PLT-1.1: Interface breakout Test
Nokia 7250 IXR-10e status
PLT-1.1: Interface breakout Test

Help

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request extends the platform breakout configuration and verification suite to include support for Juniper devices. It introduces vendor-specific logic for interface validation, component identification, and port naming conventions. Additionally, it improves test reliability by incorporating deliberate delays to ensure device stability during configuration cycles.

Highlights

  • Juniper Support: Added comprehensive support for breakout configuration and verification specifically for Juniper devices, including interface checking and component name resolution.
  • Test Stability: Introduced strategic time delays between test cases to allow hardware to stabilize during configuration changes.
  • Code Refinement: Updated test logic to include Juniper-specific handling for port naming, breakout mode verification, and hardware component retrieval.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for Juniper devices in the breakout configuration tests, including vendor-specific checks, port name generation, and component retrieval. Feedback on the changes highlights potential test flakiness caused by swapping the order of starting protocols and sleeping in configureOTG. Additionally, the reviewer recommends removing commented-out code in the Juniper port name generation and simplifying a redundant vendor switch block to improve code cleanliness and portability.

Comment thread feature/platform/tests/breakout_configuration/breakout_test.go
Comment thread feature/platform/tests/breakout_configuration/breakout_base_test.go Outdated
Comment thread feature/platform/tests/breakout_configuration/breakout_test.go Outdated
priyaranjannanda and others added 6 commits May 29, 2026 03:38
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants