Update tcam profile

[ijernoiu]

Updating tcam profile for test PF-1.6

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the TCAM (Ternary Content-Addressable Memory) profile definitions to support the new 'ngpr' profile for test PF-1.6. The changes involve restructuring the hardware configuration by removing outdated features and adding granular QoS and traffic-policy definitions, alongside new hardware counter tracking capabilities.

Highlights

• TCAM Profile Update: Replaced the 'vrf-selection-with-ip6-sip' profile with the new 'ngpr' profile in the Arista TCAM configuration.
• Feature Configuration Cleanup: Removed legacy PBR (Policy Based Routing) features and integrated comprehensive QoS and traffic-policy configurations.
• Hardware Counter Integration: Added new hardware counter features for GRE tunnels, traffic policies, IPv4 routes, and nexthops to the TCAM profile.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[OpenConfigBot]

Pull Request Functional Test Report for #5504 / f988292

No tests identified for validation.

Help

[gemini-code-assist]

Code Review

This pull request updates the aristaTcamProfileVrfSelectionExtended TCAM profile configuration in internal/cfgplugins/dut_initialize.go by renaming it to ngpr, removing several subinterface, VLAN, and PBR ACL features, and adding QoS, traffic-policy, and hardware counter features. Feedback highlights a critical conflict where the profile name ngpr is now defined in two different TCAM profiles with conflicting feature sets, which could lead to configuration overwrites or failures on Arista EOS. It is recommended to consolidate these definitions or use distinct profile names.

[gemini-code-assist]

Conflicting Definitions for Profile ngpr

Both aristaTcamProfileVrfSelectionExtended (modified here) and aristaNGPRTcamProfile (defined at line 400) now configure the same TCAM profile name ngpr (profile ngpr and system profile ngpr), but with different feature sets:

• aristaTcamProfileVrfSelectionExtended includes vrf selection and vrf selection extended but lacks pbr mpls.
• aristaNGPRTcamProfile includes pbr mpls but lacks the vrf selection features.

Since Arista EOS only supports a single active definition for a given profile name, having conflicting definitions for the same profile name across different feature types can lead to configuration overwrites, commit failures, or unexpected behavior if the switch is not fully rebooted between tests.

Recommendation:
Consider consolidating these into a single, unified ngpr profile definition that includes all required features (both vrf selection and pbr mpls), or use distinct profile names if the platform supports it.