Updating supervisor switchover test as per readme modifications#5488
Updating supervisor switchover test as per readme modifications#5488rohit-rp wants to merge 1 commit into
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the supervisor failure test suite to better align with the specified test documentation. It modifies the scale of the test by reducing the number of prefixes used and expands the test coverage to include IPv6 validation. Additionally, the test structure has been refactored to support a multi-phase validation approach, ensuring that FIB entries persist correctly across supervisor switchovers and that post-switchover programming functions as expected. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
Pull Request Functional Test Report for #5488 / 3619763Virtual Devices
Hardware Devices
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request enhances the supervisor failure test by adding IPv6 support and refactoring the route programming and traffic verification logic. Key changes include updating the test documentation, introducing specific traffic flows for IPv4 and IPv6 across initial and post-switchover phases, and utilizing helper functions for AFT telemetry validation. The number of prefixes programmed in each phase has been adjusted to 25 for each IP version. I have no feedback to provide.
rohit-rp
force-pushed
the
sup_failover
branch
2 times, most recently
from
482bb2d to
f01b4a9
Compare
| @@ -357,9 +424,6 @@ func TestSupFailure(t *testing.T) { | |||
| primaryAfterSwitch := secondaryBeforeSwitch | |||
| secondaryAfterSwitch := secondaryBeforeSwitch | |||
There was a problem hiding this comment.
There is this issue that existed where secondaryBeforeSwitch was assigned to both variables primaryAfterSwitch and secondaryAfterSwitch
| ate.OTG().StartTraffic(t) | ||
| time.Sleep(15 * time.Second) | ||
| ate.OTG().StopTraffic(t) | ||
| otgutils.LogFlowMetrics(t, ate.OTG(), top) |
There was a problem hiding this comment.
According to the readme TE-8.2.1:
Validate: Supervisor switchover is triggered using gNOI SwitchControlProcessor. Ensure gRIBI entries persist over switchover and traffic contniues to be forwarded.
The traffic must keep forwarding during switchover. however, I see in the code that it is explicitly stopped ate.OTG().StopTraffic(t)
|
|
||
| // Verify initial prefixes persist after switchover | ||
| t.Log("Verifying initial prefixes persist in telemetry after switchover...") | ||
| verifyAftTelemetry(t, args, ipv4Initial, ipv6Initial) |
There was a problem hiding this comment.
According to the readme:
Following reconnection of a gRIBI client to the new master supervisor, ensure the 100 prefixes pointing to ATE port-2 are present and traffic flows 100% from ATE port-1 to ATE port-2.
Can you add the step for the traffic validation for the first 100 routes
4 participants
Uh oh!
There was an error while loading. Please reload this page.