Add PFC Deadlock Detection timer granularity attributes#2250
Open
pinky-nexthop wants to merge 3 commits intoopencomputeproject:masterfrom
Open
Add PFC Deadlock Detection timer granularity attributes#2250pinky-nexthop wants to merge 3 commits intoopencomputeproject:masterfrom
pinky-nexthop wants to merge 3 commits intoopencomputeproject:masterfrom
Conversation
- Add SAI_PORT_ATTR_PFC_TC_DLD_TIMER_INTERVAL to saiport.h - Add SAI_SWITCH_ATTR_PFC_TC_DLD_TIMER_INTERVAL to saiswitch.h These attributes allow configuration of PFC deadlock detection timer granularity (1ms, 10ms, or 100ms) at port and switch levels. Signed-off-by: pinky-nexthop <pinky@nexthop.ai> Signed-off-by: Pinky Agrawal <pinky@nexthop.ai>
kperumalbfn
reviewed
Feb 6, 2026
| * @type sai_map_list_t | ||
| * @flags CREATE_AND_SET | ||
| * @default empty | ||
| */ |
| * @flags CREATE_AND_SET | ||
| * @default empty | ||
| */ | ||
| SAI_PORT_ATTR_PFC_TC_DLD_TIMER_INTERVAL, |
Contributor
There was a problem hiding this comment.
could you also add the unit of the granularity? Is this in milliseconds?
Address review comments: - Add explicit units (milliseconds) to documentation - Clarify that sai_map_list_t maps TC to granularity value - Explain relationship with detection timer interval attribute - Specify valid granularity values: 1, 10, or 100 milliseconds Signed-off-by: pinky-nexthop <pinky@nexthop.ai> Signed-off-by: Pinky Agrawal <pinky@nexthop.ai>
Remove detailed explanation to keep documentation concise. The brief description is sufficient to understand the attribute purpose. Signed-off-by: pinky-nexthop <pinky@nexthop.ai> Signed-off-by: Pinky Agrawal <pinky@nexthop.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These attributes allow configuration of PFC deadlock detection timer granularity (1ms, 10ms, or 100ms) at port and switch levels.