Skip to content

Add Jenkins hash to supported hash algorithms.#2233

Merged
tjchadaga merged 1 commit intoopencomputeproject:masterfrom
mikeberesford:hash
Feb 13, 2026
Merged

Add Jenkins hash to supported hash algorithms.#2233
tjchadaga merged 1 commit intoopencomputeproject:masterfrom
mikeberesford:hash

Conversation

@mikeberesford
Copy link
Contributor

Add the option to configure the hash algorithm to the lower or upper 16 bits of a Jenkins hash algorithm
(https://en.wikipedia.org/wiki/Jenkins_hash_function). This provides a stronger alternative to the CRC-based algorithms where supported.

Copy link
Contributor

@JaiOCP JaiOCP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

Copy link
Contributor

@JaiOCP JaiOCP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rlhui
Copy link
Collaborator

rlhui commented Dec 18, 2025

please add hld and also add that capability should be used before using it, thanks.

@rlhui rlhui added the reviewed PR is discussed in SAI Meeting label Dec 18, 2025
@mikeberesford
Copy link
Contributor Author

In the call today it was mentioned that there was a capability to query the switch supported hash algorithms. However, when reviewing the switch APIs I don't see the capability query for the supported hash algorithms - I see APIs to set/get the defaults, but no list query at the switch level. Since I don't have access to the Zoom meeting chat, is there a pointer to what was being discussed?

@rlhui
Copy link
Collaborator

rlhui commented Dec 19, 2025

In the call today it was mentioned that there was a capability to query the switch supported hash algorithms. However, when reviewing the switch APIs I don't see the capability query for the supported hash algorithms - I see APIs to set/get the defaults, but no list query at the switch level. Since I don't have access to the Zoom meeting chat, is there a pointer to what was being discussed?

Hi, can use this one sai_status_t sai_query_attribute_enum_values_capability

@mikeberesford
Copy link
Contributor Author

I've updated the PR with documentation on how the configuration works, please take a look.

@abhishek-7
Copy link

Hi @rlhui, gentle ping. Can you please help review the documentation?

@tjchadaga
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mikeberesford
Copy link
Contributor Author

Synced my branch since that may have caused the metadata check failure

@tjchadaga
Copy link
Collaborator

@mikeberesford , i think you might need to squash your commits as well

@tjchadaga
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Add the option to configure the hash algorithm to the lower or upper 16
bits of a Jenkins hash algorithm
(https://en.wikipedia.org/wiki/Jenkins_hash_function). This provides a
stronger alternative to the CRC-based algorithms where supported.

Signed-off-by: Mike Beresford <mberes@google.com>
@mikeberesford
Copy link
Contributor Author

Thanks @tjchadaga - think I've got the commits squashed and re-pushed, hopefully that takes care of it

@tjchadaga
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@tjchadaga tjchadaga merged commit 64be3db into opencomputeproject:master Feb 13, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

reviewed PR is discussed in SAI Meeting

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments