feat: rework public and permanent link resolving - #2981
Open
JammingBen wants to merge 3 commits into
Open
Conversation
JammingBen
force-pushed
the
feat/improve-private-link-resolving
branch
from
July 30, 2026 06:04
b0a94bc to
fbea00c
Compare
Stop resolving single file public and permanent links into the file list before opening a file editor and instead directly resolve into the editor. For users, this means faster resolving and less flicker. For the server, this means reduced server load because of less requests.
JammingBen
force-pushed
the
feat/improve-private-link-resolving
branch
from
July 30, 2026 07:19
fbea00c to
8a96d12
Compare
JammingBen
marked this pull request as ready for review
July 30, 2026 10:03
Member
Contributor
I added task for that opencloud-eu/qa#94 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stop resolving single file public and permanent links into the file list before opening a file editor and instead directly resolve into the editor.
For users, this means faster resolving and less flicker. For the server, this means reduced server load because of less requests. It also makes the code more elegant since we can remove the
openWithDefaultAppquery handling from the file lists.Numbers
Opening one text file:
Permanent link
Public link Unauthenticated
Public link Authenticated
closes #2961
fixes #2987