Open
Conversation
JammingBen
commented
Mar 17, 2026
| }) | ||
|
|
||
| onMounted(async () => { | ||
| mailComposeEventToken = eventBus.subscribe('app.mail.show-compose-mail', onComposeMail) |
Member
Author
There was a problem hiding this comment.
Using an event bus is the easiest solution I can think of right now. Another possibility would be to work with a store that keeps track of the visibility of the mail widget. But I feel like this wouldn't be an improvement.
AlexAndBear
approved these changes
Mar 17, 2026
AlexAndBear
force-pushed
the
refactor/mail-nav
branch
from
d1a1e74 to
a9a67dd
Compare
The visibility of the mail widget was controlled within the component as well as on the outside. This doesn't make sense, so this change simplifies it to control the visibility from the outside only.
AlexAndBear
force-pushed
the
refactor/mail-nav
branch
from
a9a67dd to
733eec7
Compare
Member
@JammingBen made this quick change on this PR. The audacity 🫨 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the mail nav to use the runtime one instead of its own implementation.
Also simplifies the visibility handling of the mail widget a bit. It was controlled within the component as well as on the outside. This doesn't make sense, so this change simplifies it to control the visibility from the outside only.
Known issue
The mobile 100% view of the nav currently doesn't work.
Next steps
Make the nav look nice like in other apps.