feat(graph): accept user name or id in GetUserDrive - #3243
Open
dschmidt wants to merge 1 commit into
Open
Conversation
dschmidt
force-pushed
the
fix/graph-get-user-drive-id-or-name
branch
from
August 5, 2026 11:08
fa8f9ff to
d7c4118
Compare
dschmidt
changed the title
GetUserDrive only resolved the personal drive when the {user-id} path
segment was the user's opaque id; a user name (which GetUser accepts)
returned 404. Resolve the segment through the identity backend first
(skipping the /me/drive self case), so both an id and a name work. Also
add GetUserDrive to the Service interface, consistent with the other
user handlers.
dschmidt
force-pushed
the
fix/graph-get-user-drive-id-or-name
branch
from
August 5, 2026 11:09
d7c4118 to
d806844
Compare
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Duplication | 340 |
🟢 Coverage 55.56% diff coverage · +0.04% coverage variation
Metric Results Coverage variation ✅ +0.04% coverage variation (-1.00%) Diff coverage ✅ 55.56% diff coverage Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (76ff13b) 84009 19267 22.93% Head commit (d806844) 84017 (+8) 19300 (+33) 22.97% (+0.04%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#3243) 9 5 55.56% Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
dschmidt
marked this pull request as ready for review
August 5, 2026 11:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
GET /v1.0/users/{user-id}/drive(GetUserDrive) only resolved the personal drive when the{user-id}path segment was the user's opaque id. A user name, which the siblingGET /v1.0/users/{user-id}(GetUser) accepts, returned404 no drive returned from storage.Fix
The handler passed the raw path segment straight into the storage space filter, which only matches the opaque id. It now resolves the segment through the identity backend first (the same
identityBackend.GetUser(nameOrID)idiom used by GetUser/DeleteUser), skipping the/me/driveself case. Both an id and a name work; the empty-segment case (own drive) is unchanged.Also added
GetUserDriveto theServiceinterface, consistent with the other user handlers (GetUser, GetMe, ...), so it is callable via the interface in tests.Tests
Added a focused test asserting the name is resolved via the identity backend before the storage lookup. Existing graph service tests stay green.