fix(thumbnails): pick audio cover art deterministically - #3208
Draft
dschmidt wants to merge 3 commits into
Draft
Conversation
Switch to the dschmidt/tag fork and select the front cover (picture type 0x03) when tagged, else the first available picture, instead of the lib's single non-deterministic Picture().
Not up to standards ⛔🟢 Coverage
|
| Metric | Results |
|---|---|
| Coverage variation | ✅ +0.01% coverage variation (-1.00%) |
| Diff coverage | ✅ 100.00% diff coverage |
Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (c7c0551) 83018 19577 23.58% Head commit (8ee6ad4) 83027 (+9) 19586 (+9) 23.59% (+0.01%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>
Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#3208) 10 10 100.00% Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #3198.
The thumbnails
AudioDecoderuseddhowden/tag's singlePicture(), which is non-deterministic when an audio file embeds multiple pictures (e.g. front + back cover). This switches to my fork (dschmidt/tag, addsPictures()+ aRawTypebyte) and selects deterministically: the tagged front cover (picture type 0x03) if present, otherwise the first available picture. Many taggers store the cover as type "Other" (0x00) rather than front, so the fallback is the common case.Fork PR: dschmidt/tag#1 (merged to master).