feat(search): video facet - #3201
Draft
dschmidt wants to merge 1 commit into
Draft
Conversation
Not up to standards ⛔
|
dschmidt
force-pushed
the
feat/search-video-facet
branch
from
July 29, 2026 23:13
32dc7e2 to
5aa11c6
Compare
dschmidt
force-pushed
the
feat/search-video-facet
branch
from
July 30, 2026 11:41
5aa11c6 to
22f66de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #3198 (tika facets).
Draft: adds the video facet (dimensions, duration, codec, audio stream details) to the search index, the search API and the graph driveItem.
Maps what Apache Tika exposes for MP4/MOV today:
width,height,duration,fourCC(video codec),audioSamplesPerSecond,audioChannels. Verified against the pinned Tika 4.0 snapshot with a realtestVideoMp4.mp4.Tika stores the video track dimensions under the same
tiff:ImageWidth/tiff:ImageLengthkeys it uses for images (viaMetadata.IMAGE_WIDTH), so image and video would otherwise both match.getImageis now gated on theimage/content type andgetVideoonvideo/, inside the respective facet function, so a file gets exactly one of the two.Still missing in Tika (left as TODOs in
tika_video.goand the test):bitrate— Tika exposes no video bitrate; would need computing (media size / duration).frameRate— metadata-extractor'sMp4VideoDirectoryhas no frame-rate tag; would need computing from the sample-timing table.audioBitsPerSample—Mp4SoundDirectory.TAG_AUDIO_SAMPLE_SIZEexists butMP4Parserdoesn't map it (easy to add upstream, like theaudio:*keys).audioFormat—MP4Parseronly setsxmpDM:audioCompressorfor audio-typed files (and to the container major brand, not the codec), so it never fires for avideo/*file. Needs tika to expose the audio track's codec.Mono/Stereoenum and drops >2 channels, so we map it heuristically; a raw count from Tika would be cleaner.Needs a separate reva change, not includable here (same as the motion-photo PR): the WebDAV PROPFIND handler must know the
videokeys to expose the facet over WebDAV. It lives in vendored reva, so it needs its own reva PR + dependency bump. The required diff: