feat(search): motion photo facet - #3200
Draft
dschmidt wants to merge 3 commits into
Draft
Conversation
Not up to standards ⛔
|
This was referenced Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #3198 (tika facets).
Draft: adds the Google Motion Photo facet (
version,presentationTimestampUs,videoSize) end to end.ftypbox.MotionPhotosearch proto message + facet, wires it through the bleve and OpenSearch backends and the graph driveItem (@libre.graph.motionPhoto).Two preparatory commits first:
getFirstValuenow tries multiple metadata keys (Motion Photo vs legacy MicroVideo), and the content retriever gainsRetrieveRange(single HTTP range request, with a full-file skip fallback).Needs a separate reva change, not includable here: the WebDAV PROPFIND handler must know the
motionPhotokeys to expose the facet over WebDAV. It lives in vendored reva, so it needs its own reva PR + dependency bump. The required diff: