Skip to content

Always enable favorites, remove FRONTEND_ENABLE_FAVORITES flag#2494

Merged
rhafer merged 1 commit intoopencloud-eu:mainfrom
pascalwengerter:favorites-graph-api
Mar 18, 2026
Merged

Always enable favorites, remove FRONTEND_ENABLE_FAVORITES flag#2494
rhafer merged 1 commit intoopencloud-eu:mainfrom
pascalwengerter:favorites-graph-api

Conversation

@pascalwengerter
Copy link
Contributor

Description

After #2454, favorites still arent' announced unless a feature flag is being set. From my understanding, this can be dropped in favor of just announcing the availabilty/capability of handling favorites?

Related Issue

  • See web issue tracker

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation added

@pascalwengerter
Copy link
Contributor Author

@rhafer @aduffeck I'm not sure about the bigger picture (as in, e.g., "does this work regardeless of underlying file system"). Please do chime in if there's necessary changes. A corresponding PR for enabling the "new" favorites in web will arrive soon

@sonarqubecloud
Copy link

@pascalwengerter
Copy link
Contributor Author

Also unsure about the changelog situation? I'd have expected an item regarding favorites but can't find anything to append to

Copy link
Member

@aduffeck aduffeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this change. While there are still storage drivers in our reva which do not implement the new favorites API all of the supported drivers do.

If we need this in the future we can always bring it back, but for now I'd say we keep it simple.

@aduffeck
Copy link
Member

Also unsure about the changelog situation? I'd have expected an item regarding favorites but can't find anything to append to

We use the ready-release-go plugin to generate a changelog for us. #2451 has an according entry for the backend change.

@rhafer rhafer merged commit 2244f86 into opencloud-eu:main Mar 18, 2026
61 checks passed
@pascalwengerter pascalwengerter deleted the favorites-graph-api branch March 18, 2026 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants