poc: User share manager for space membership#2492
Draft
rhafer wants to merge 3 commits intoopencloud-eu:mainfrom
Draft
poc: User share manager for space membership#2492rhafer wants to merge 3 commits intoopencloud-eu:mainfrom
rhafer wants to merge 3 commits intoopencloud-eu:mainfrom
Conversation
This gets us rid of quite a bit of special casing for space permission. Also provides us with "real" permission IDs instead of those faked "u:<userid>" ones.
rhafer
changed the title
|
1 task
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proof of concept implementation for #2319. (Persisting Space-Membership in the share-manager)
Requires an adjustment to the CS3 API. Basically just an addtional sharefilter-type: rhafer/cs3apis@6333ce5
The required reva changes are here: https://github.com/rhafer/reva/tree/spaces-in-sharemanager. The rest is mainly accomplished by settting
use_common_space_root_share_logicto `true. If we decide to move forward with this I'd suggest to remove that option and make the behavior the default. Should get us rid of a bit more code in reva.As you can see, the changes simplifies the sharing code in the graph service quite a bit as it removes quite a few of the "is this a space root" special cases.