feat(setup): offer native Windows and WSL gateway modes#938
Conversation
|
Codex review: needs changes before merge. Reviewed July 10, 2026, 8:36 PM ET / July 11, 2026, 00:36 UTC. Summary Reproducibility: yes. for the blocking review defect: launch the tray with a managed native gateway, terminate that gateway after startup, and observe whether it restarts without relaunching the tray. Source inspection gives high confidence that no later supervision trigger currently exists, although this read-only Linux review did not execute the Windows process scenario. Review metrics: 4 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Copy recommended automerge instructionNext step before merge
Maintainer decision needed
Security Review findings
Review detailsBest possible solution: Keep WSL 2 visibly recommended for its stronger isolation, retain native Windows as an explicit lower-isolation option, and add ownership-checked recurring or event-driven supervision that restarts unexpected native exits without overriding an explicit user stop. Do we have a high-confidence way to reproduce the issue? Yes for the blocking review defect: launch the tray with a managed native gateway, terminate that gateway after startup, and observe whether it restarts without relaunching the tray. Source inspection gives high confidence that no later supervision trigger currently exists, although this read-only Linux review did not execute the Windows process scenario. Is this the best way to solve the issue? No, not yet. The dual-mode setup direction and ownership model are reasonable, but a one-time startup ensure does not provide the ongoing availability expected from an app-managed local gateway. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 622c0e27c6b0. Label changesLabel justifications:
Evidence reviewedSecurity concerns:
Acceptance criteria:
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
Review history (3 earlier review cycles)
|
|
@steipete this is a massive deal, we will do a bunch of testing and report back |
|
Can we consider shipping the native Windows experience as an opt-in capability initially? Running OpenClaw natively on Windows without any form of containment appears too risky for many enterprise scenarios. At the same time, introducing containment from day one may significantly impact usability until we have sufficient experience tuning and validating the appropriate policy set. An opt-in approach would allow us to gather real-world feedback, understand customer adoption patterns, and iteratively refine the containment model before making it the default experience. For reference, the current containment work is tracked in Containment PR - openclaw/openclaw#97086 |
Pre-merge blockers and native/WSL parity gapsI took a pass through the PR locally and compared the native Windows path against the current WSL path and the macOS gateway-control model. I think these should be addressed before merge. Merge blockers / must-fix before merge
Important parity gaps
Recommended framing changeCurrent PR wording says native is recommended because it is simpler/no WSL. I’d change the product framing to:
Things that look okay
|
b79734f to
6bda31f
Compare
Restore WSL as the recommended local setup path while keeping native Windows available as the simpler lower-isolation option. Avoid desktop-only wizard dead ends by auto-deferring terminal hatch and skipping redundant gateway service runtime prompts. Add setup-owned native gateway lifecycle metadata, controls, keepalive suppression after explicit stop, and stale node token recovery. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
6bda31f to
51ed356
Compare
Summary
Builds on the onboarding redesign from #925.
Verification
2026.6.11version unchangedThe Parallels validation VM can run WSL 1 but cannot provide the nested virtualization required for WSL 2, so a fresh WSL 2 provisioning run is not claimed here. The WSL choice/review path and runtime-selection/switching behavior remain covered by the setup test suite and existing CI E2E lane.