feat(sheets): add gradient conditional formatting#901
Conversation
|
Codex review: passed. Reviewed July 4, 2026, 11:02 PM ET / 03:02 UTC. Summary Reproducibility: not applicable. as a bug reproduction; this is a feature PR. Source inspection confirms current main lacks a gradient-rule creation path, and the patch adds one with request-building and dry-run coverage. Review metrics: 2 noteworthy metrics.
Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Mantis proof suggestion Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land the focused gradient-rule flag after CI and, ideally, live redacted Sheets proof confirm the generated request is accepted and visibly applies a color scale. Do we have a high-confidence way to reproduce the issue? Not applicable as a bug reproduction; this is a feature PR. Source inspection confirms current main lacks a gradient-rule creation path, and the patch adds one with request-building and dry-run coverage. Is this the best way to solve the issue? Yes: extending the existing AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against c0aac99f6be6. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
Summary
--gradient-rule-jsontogog sheets conditional-format addfor Sheets APIConditionalFormatRule.gradientRule--type/--expr/--format-jsonpath and reject mixed boolean/gradient inputsRelease note
gog sheets conditional-format addcan now create gradient conditional formatting rules from Sheets API JSON.Fixes #900
Validation
go test ./internal/sheetsconditional ./internal/cmdmake docs-commandsmake ci