feat(slides): add skip and unskip commands - #1009
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
|
Codex review: needs maintainer review before merge. Reviewed August 22, 2026, 9:29 AM ET / 13:29 UTC. ClawSweeper reviewWhat this changesAdds Merge readinessThis PR remains necessary: current main has no first-class Slides skip/unskip command or skipped-state list output. The implementation is focused, consistent with adjacent Slides commands, and supported by live after-fix evidence; no discrete repair blocker was found. Priority: P3 Review scores
Verification
Live VerificationCommand: Result: FAIL (failed) — execution before step 1 Assertions:
How this fits togetherThe Slides CLI turns presentation and slide IDs into Google Slides API batch-update requests, then reports the resulting state for terminal and JSON users. These commands alter a slide’s presentation visibility while leaving the slide in the deck. flowchart LR
A[Presentation and slide IDs] --> B[Skip or unskip command]
B --> C[Validate identifiers]
C --> D[Slides API batch update]
D --> E[Slide visibility state]
E --> F[List and JSON output]
Before merge
Agent review detailsSecurityNone. Review metrics
Technical reviewBest possible solution: Merge the focused API-backed command pair after ordinary maintainer review and normal merge checks, preserving the tested explicit-false unskip serialization. Do we have a high-confidence way to reproduce the issue? Not applicable as a defect report; the PR supplies a high-confidence live Google Slides verification of the new command behavior at its reviewed head. Is this the best way to solve the issue? Yes. Mapping the existing Google Slides AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against ab7e0ed706f9. LabelsLabel justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
History |
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
Summary
gog slides skip-slideandgog slides unskip-slidehide-slideandunhide-slidealiases for familiar terminologyisSkippedstate inslides list-slidesThe commands use
updateSlidePropertieswith anisSkippedfield mask. Unskipping explicitly serializesisSkipped: falserather than allowing Go's zero-value omission to drop it.Testing
make SHELL="$(command -v bash)" ciLive Google Slides verification
Run from reviewed head
b6635a5d5ca406984eb60707b8252b7640059fdbagainst a temporary three-slide Google Slides presentation created with the CLI. Presentation and slide IDs were redacted after capture; the temporary presentation was moved to Drive trash afterwards.Assertions performed on the captured JSON:
skip-slide, exactly the target slide changed toisSkipped: trueisSkipped: falseunskip-slide, the target returned toisSkipped: falseUser-facing changes
slides list-slidesadds aSKIPPEDcolumn to text output and an additiveisSkippedfield to each JSON slide record.