build: move Go floor to 1.26.6 - #88
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
|
Codex review: needs real behavior proof before merge. Reviewed August 14, 2026, 4:17 AM ET / 08:17 UTC. ClawSweeper reviewWhat this changesThe PR raises crawlkit’s declared Go minimum from 1.26.5 to 1.26.6 and updates public install guidance and the changelog. Merge readiness⛔ Blocked until real behavior proof is added - 5 items remain Keep open: the focused Go-floor update needs removal of the release-owned changelog edit and real after-fix terminal proof before merge. Likely related people
Priority: P2 Review scores
Verification
How this fits togethercrawlkit is a shared Go module consumed by downstream archive applications. Its Go version directive controls the minimum toolchain consumers need to build the library, while the README communicates that requirement. flowchart LR
A[Downstream applications] --> B[Go toolchain]
B --> C[Module version requirement]
C --> D[Build and validation]
C --> E[Installation guidance]
D --> F[Shared crawlkit library]
Before merge
Findings
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Keep Do we have a high-confidence way to reproduce the issue? Not applicable: this PR changes a build prerequisite rather than repairing a runtime behavior with a user reproduction path. Is this the best way to solve the issue? No: the module and README edits are aligned, but normal PRs must not edit the release-owned changelog and the security-floor claim needs visible after-fix evidence. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against a7025e21fc5c. LabelsLabel changes:
Label justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
|
Summary
Verification
GOTOOLCHAIN=go1.26.6 GOWORK=off go build ./...GOTOOLCHAIN=go1.26.6 GOWORK=off go test ./...GOTOOLCHAIN=go1.26.6 GOWORK=off go vet ./...GOTOOLCHAIN=go1.26.6 GOWORK=off go run golang.org/x/vuln/cmd/govulncheck@v1.6.0 ./...— no reachable vulnerabilitiesGOTOOLCHAIN=go1.26.6 GOWORK=off go run ./cmd/crawlctl --help