Open
Conversation
This involves refactoring Opencensus.Plug.Trace to move some code out of quote (to make it exposed to Dialyzer) and adding some warnings to Dialyzer config (those were the default until Dialyxir 0.4).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This involves refactoring Opencensus.Plug.Trace to move some code out of quote (to make it exposed to Dialyzer) and adding some warnings to Dialyzer config (those were the default until Dialyxir 0.4).
An alternative would be to not refactor the module, but instead create a dummy one somewhere in
test/that uses this module and triggers Dialyzer errors. However given that there is a Credo check that discourages long quote blocks, the approach proposed in this PR may have an additional benefit.