Force a file copy when cloning mediapackage elements#7374
Open
mtneug wants to merge 3 commits intoopencast:r/19.xfrom
Open
Force a file copy when cloning mediapackage elements#7374mtneug wants to merge 3 commits intoopencast:r/19.xfrom
mtneug wants to merge 3 commits intoopencast:r/19.xfrom
Conversation
Cloning mediapackage elements should also copy the file in the workspace. Otherwise, operations performed on one file will affect multiple mediapackage elements.
mtneug
added a commit
to tales-media/fork-opencast-opencast
that referenced
this pull request
Feb 10, 2026
Member
|
You've got this in prod @mtneug? |
Member
Author
Yes, but we don't use every WOH that got changed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some operations clone mediapackage elements and add the cloned element back to the mediapackage, e.g. when the
editoris skipped and only clones the source elements to the targets. This should result in a copy of the underlying file in the workspace, however, not all operations did that. This PR introduces a new helper function for cloning mediapackage elements that also creates a file copy.Note that the following places, where mediapackage elements are cloned, remain unchanged, either because the nature of the clone is different (e.g. building the distribution mediapackage object) or the file is already copied in another way:
XACMLAuthorizationService.java:285AdaptivePlaylist.java:758AwsS3DistributionServiceImpl.java:543AwsS3DistributionServiceImpl.java:847DownloadDistributionServiceImpl.java:354DownloadDistributionServiceImpl.java:482WowzaStreamingDistributionService.java:757PublishEngageWorkflowOperationHandler.java:729PublishEngageWorkflowOperationHandler.java:739DublinCoreXmlFormat.java:187SchedulerServiceImpl.java:545SchedulerServiceImpl.java:758SubtitleTimeshiftWorkflowOperationHandler.java:225DuplicateEventWorkflowOperationHandler.java:396DuplicateEventWorkflowOperationHandler.java:505How to test this patch
Could be hard to confirm this without an attached debugger. Pause the execution after a clone and verify that the mediapackage object does not contain elements that share one URL.
Your pull request should…