fix(openapi-typescript): handle readonly arrays in ReadonlyArray helper#2749
Open
y-hsgw wants to merge 1 commit intoopenapi-ts:mainfrom
Open
fix(openapi-typescript): handle readonly arrays in ReadonlyArray helper#2749y-hsgw wants to merge 1 commit intoopenapi-ts:mainfrom
y-hsgw wants to merge 1 commit intoopenapi-ts:mainfrom
Conversation
👷 Deploy request for openapi-ts pending review.Visit the deploys page to approve it
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR updates the
ReadonlyArray<T>helper used byopenapi-typescriptso it recognizesreadonly unknown[]in addition to mutable arrays.Fixes: #2714
How to Review
Check
packages/openapi-typescript/src/lib/ts.tsto confirm the array guard now usesreadonly unknown[].The snapshot updates in
packages/openapi-typescript/test/node-api.test.tsreflect the generated output change and should match the new helper behavior.Checklist
docs/updated (if necessary)pnpm run update:examplesrun (only applicable for openapi-typescript)