Uses Regex instead of fancy-regex - 6x speedup#331
Open
Majdoddin wants to merge 1 commit intoopenai:mainfrom
Open
Uses Regex instead of fancy-regex - 6x speedup#331Majdoddin wants to merge 1 commit intoopenai:mainfrom
Majdoddin wants to merge 1 commit intoopenai:mainfrom
Conversation
…a 6x speedup. To make the regex patterns compatible with Regex, drops part of thpatterns for whitespaces, and handles the whitespaces with scripting instead of regex. Still with exact same output. _encode_native calls _encode_ordinary_native_impl directly (_encode_ordinary_native is a wrapper of _encode_ordinary_native now).
|
@bigheemseafood |
tmm1
pushed a commit
to anysphere/tiktoken-rs
that referenced
this pull request
Nov 9, 2024
Based on openai#331 Uses Regex in _encode_ordinary_native instead of fancy-regex, to get a 6x speedup. To make the regex patterns compatible with Regex, drops part of thpatterns for whitespaces, and handles the whitespaces with scripting instead of regex. Still with exact same output. _encode_native calls _encode_ordinary_native_impl directly (_encode_ordinary_native is a wrapper of _encode_ordinary_native now).
|
Thanks for your work on this! I noticed this code block which sounds like it would need to change along with these regexes? Lines 405 to 409 in 6352764 |
Author
|
@tmm1 I've implement it for encode_ordinary(). Than part is for unstable encoding. |
This was referenced Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR realizes the wish expressed in current code to use the faster
Regex.The text is splitted to pieces, before tokenization, according to regular expression patterns. This PR drops a lookahead part of the pattern, the part for catching the whitespaces, and handles the whitespaces with scripting instead, with mathematically provable exactly same output.
This makes it possible to use linear-time
Regexinstead offancy-regex, asRegexdoes not support lookahead, resulting in a 14x speedup of pattern matching. As pattern matching currently comprises 90% of the encoding runtime, the total runtime is boosted 6x.Although
fancy_regexdelegates toRegex, when the pattern has no special features, it is still some 10% slower in test, thus we directly useRegex.This improvement is for pattern matching of the parts with ordinary text. Catching the special tokens is still done with
fancy_regex.Tests
For encoding o200k_base (used by model GPT-4o)