fix(ci): update Bedrock lockfile during releases - #509
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Castiron custom code✅ No new custom-code files detected. 48 mixed files remain; 0 existing customizations changed. Compared 48 existing customizations unchanged
8 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 32489607935 --repo openai/openai-ruby \
--name castiron-custom-code-32489607935-1 --dir /tmp/castiron-custom-code-32489607935-1
git apply --stat /tmp/castiron-custom-code-32489607935-1/custom-code.patch
cat /tmp/castiron-custom-code-32489607935-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin d873fcf645347ab771b5f92ec8598fb3f83a0c7f b0d5eae335d6af9de5a8932953406dc3ed025274
python3 scripts/castiron/custom_code_report.py report \
--base d873fcf645347ab771b5f92ec8598fb3f83a0c7f \
--head b0d5eae335d6af9de5a8932953406dc3ed025274 --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-b0d5eae335d6
cat /tmp/castiron-custom-code-b0d5eae335d6/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: edd079a33d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jbeckwith-oai
left a comment
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Reviewed the Bedrock frozen-lockfile release fix and the focused release regressions. Effective Release Please configuration, exact updater-marker placement, current SDK-version consistency, and isolated version replacement are all protected against marker/configuration regressions. Ruby/Bedrock, packaging, lint, compatibility, Castiron, and security checks look good.
2 participants
Summary
Release PR #434 bumps the SDK to 0.81.0, but leaves the Bedrock bundle's local
openaigem at 0.80.0. Its Bedrock CI job fails during Ruby setup because Bundler refuses to change path-gem versions in frozen mode.Register
gemfiles/bedrock.gemfile.lockin Release Please'sextra-filesand mark only the local SDK version for replacement. The pinned Ruby strategy already updates the root lockfile; extra files use the generic, annotation-based updater. No runtime code or dependency versions change in this PR.The contribution guide and agent instructions note that the markers must be preserved after a Bundler lockfile rewrite. Two small tests in
test/scripts/release_workflow_test.rbenforce the effectiveextra-filesentry, marker placement around only the SDK version, and stable-version replacement without dependency changes. The existingrake testdiscovery runs them in the regular Ruby CI jobs; no new dependencies or workflow steps are needed. After this merges intomain, the next Release Please run can refresh #434 with the matching Bedrock version. This PR does not publish a release.