Skip to content

fix: preserve fast-format arguments - #508

Open
jbeckwith-oai wants to merge 1 commit into
mainfrom
codex/preserve-fast-format-arguments
Open

fix: preserve fast-format arguments#508
jbeckwith-oai wants to merge 1 commit into
mainfrom
codex/preserve-fast-format-arguments

Conversation

@jbeckwith-oai

Copy link
Copy Markdown
Contributor

Summary

  • resolve relative path-list inputs before changing to the repository root
  • forward every formatter argument after the path-list file
  • add process-level regression coverage for both behaviors

Scope and compatibility

Affected paths are scripts/fast-format and test/scripts/fast_format_test.rb. The direct consumer is the developer fast-format workflow. Both files are handwritten repository artifacts, not generated output. This does not change the public SDK API, runtime transport, wire formats, dependencies, supported Ruby versions, or generated code.

Validation

  • focused regression test: 2 runs, 5 assertions, passing
  • script subsystem: 76 runs, 611 assertions, passing
  • repository lint: 2,715 files, no offenses
  • Sorbet: no errors
  • RBS validation: 1,236 files, no errors
  • Bash syntax and git diff --check: passing
  • thermo-nuclear code-quality review: no findings
  • full suite with the documented mock: 1,089 runs, 9,793 assertions, 0 failures, 1 pre-existing realtime proxy error; the identical 7-test/26-assertion error reproduces on base commit 8977731

@jbeckwith-oai jbeckwith-oai added the codex-maintenance Low-risk maintenance changes created by Codex label Aug 21, 2026
@github-actions

github-actions Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Castiron custom code

✅ No new custom-code files detected.

50 mixed files remain; 0 existing customizations changed.

Compared 8977731a59da6f7d523f9b22. Generated baselines verified.

50 existing customizations unchanged
  • lib/openai.rb
  • lib/openai/client.rb
  • lib/openai/models/chat/chat_completion_message.rb
  • lib/openai/models/chat/chat_completion_message_function_tool_call.rb
  • lib/openai/models/chat/completion_create_params.rb
  • lib/openai/models/response_format_json_schema.rb
  • lib/openai/models/responses/function_tool.rb
  • lib/openai/models/responses/response.rb
  • lib/openai/models/responses/response_create_params.rb
  • lib/openai/models/responses/response_format_text_config.rb
  • lib/openai/models/responses/response_format_text_json_schema_config.rb
  • lib/openai/models/responses/response_function_tool_call.rb
  • lib/openai/models/responses/response_function_web_search.rb
  • lib/openai/models/responses/response_output_text.rb
  • lib/openai/models/responses/tool.rb
  • lib/openai/resources/beta/responses.rb
  • lib/openai/resources/beta/threads.rb
  • lib/openai/resources/chat/completions.rb
  • lib/openai/resources/files.rb
  • lib/openai/resources/responses.rb
  • lib/openai/resources/vector_stores/file_batches.rb
  • lib/openai/resources/vector_stores/files.rb
  • lib/openai/resources/webhooks.rb
  • rbi/openai/client.rbi
  • rbi/openai/models/chat/chat_completion_message.rbi
  • rbi/openai/models/chat/chat_completion_message_function_tool_call.rbi
  • rbi/openai/models/chat/completion_create_params.rbi
  • rbi/openai/models/response_format_json_schema.rbi
  • rbi/openai/models/responses/response.rbi
  • rbi/openai/models/responses/response_create_params.rbi
  • rbi/openai/models/responses/response_function_tool_call.rbi
  • rbi/openai/models/responses/response_function_web_search.rbi
  • rbi/openai/models/responses/response_output_text.rbi
  • rbi/openai/resources/chat/completions.rbi
  • rbi/openai/resources/files.rbi
  • rbi/openai/resources/responses.rbi
  • rbi/openai/resources/vector_stores/file_batches.rbi
  • rbi/openai/resources/vector_stores/files.rbi
  • rbi/openai/resources/webhooks.rbi
  • scripts/castiron/README.md

10 more in the full report.

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 32448082097 --repo openai/openai-ruby \
  --name castiron-custom-code-32448082097-1 --dir /tmp/castiron-custom-code-32448082097-1
git apply --stat /tmp/castiron-custom-code-32448082097-1/custom-code.patch
cat /tmp/castiron-custom-code-32448082097-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin 851f53438f5afc7f32e3ccbe866fd03bbade576a 6f7d523f9b22955ef5231429f036d651165ac363
python3 scripts/castiron/custom_code_report.py report \
  --base 851f53438f5afc7f32e3ccbe866fd03bbade576a \
  --head 6f7d523f9b22955ef5231429f036d651165ac363 --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-6f7d523f9b22
cat /tmp/castiron-custom-code-6f7d523f9b22/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

@jbeckwith-oai
jbeckwith-oai marked this pull request as ready for review August 21, 2026 04:45
@jbeckwith-oai
jbeckwith-oai requested a review from a team as a code owner August 21, 2026 04:45
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 21, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-21T04:46:52.629124Z 6f7d523 Draft marked ready
🔒 Security Review Completed 2026-08-21T04:47:28.254637Z 6f7d523 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@openai-sdks

openai-sdks Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

OkTest Summary

237/237 SDK tests passed in 11.482s for Ruby SDK PR #508.

Test results — 42 files
Test Result Time
tests/chat-completions-complex-body.test.ts ✅ Passed 284ms
tests/chat-completions-create.test.ts ✅ Passed 331ms
tests/chat-completions-stream.test.ts ✅ Passed 152ms
tests/files-content-binary.test.ts ✅ Passed 248ms
tests/files-create-multipart.test.ts ✅ Passed 203ms
tests/files-list-pagination.test.ts ✅ Passed 169ms
tests/initialize-config.test.ts ✅ Passed 196ms
tests/instance-isolation.test.ts ✅ Passed 239ms
tests/models-list.test.ts ✅ Passed 183ms
tests/responses-background-lifecycle.test.ts ✅ Passed 235ms
tests/responses-body-method-errors.test.ts ✅ Passed 681ms
tests/responses-cancel-timeout.test.ts ✅ Passed 287ms
tests/responses-cancel.test.ts ✅ Passed 315ms
tests/responses-compact-retries.test.ts ✅ Passed 408ms
tests/responses-compact.test.ts ✅ Passed 374ms
tests/responses-create-advanced-stream.test.ts ✅ Passed 204ms
tests/responses-create-advanced.test.ts ✅ Passed 273ms
tests/responses-create-disconnect.test.ts ✅ Passed 1.032s
tests/responses-create-errors.test.ts ✅ Passed 363ms
tests/responses-create-malformed-api-responses.test.ts ✅ Passed 213ms
tests/responses-create-retries.test.ts ✅ Passed 350ms
tests/responses-create-stream-failures.test.ts ✅ Passed 178ms
tests/responses-create-stream-timeout.test.ts ✅ Passed 233ms
tests/responses-create-stream-wire.test.ts ✅ Passed 2.614s
tests/responses-create-stream.test.ts ✅ Passed 131ms
tests/responses-create-terminal-states.test.ts ✅ Passed 366ms
tests/responses-create-timeout.test.ts ✅ Passed 279ms
tests/responses-create.test.ts ✅ Passed 340ms
tests/responses-delete.test.ts ✅ Passed 346ms
tests/responses-input-items-errors.test.ts ✅ Passed 204ms
tests/responses-input-items-list.test.ts ✅ Passed 202ms
tests/responses-input-items-options.test.ts ✅ Passed 203ms
tests/responses-input-tokens-count-timeout.test.ts ✅ Passed 377ms
tests/responses-input-tokens-count.test.ts ✅ Passed 350ms
tests/responses-malformed-inputs.test.ts ✅ Passed 2.264s
tests/responses-not-found-errors.test.ts ✅ Passed 546ms
tests/responses-parse.test.ts ✅ Passed 284ms
tests/responses-retrieve-retries.test.ts ✅ Passed 304ms
tests/responses-retrieve.test.ts ✅ Passed 369ms
tests/responses-stored-method-errors.test.ts ✅ Passed 830ms
tests/retry-behavior.test.ts ✅ Passed 3.121s
tests/sdk-error-shape.test.ts ✅ Passed 492ms

View OkTest run #32448083712

SDK merge (8a0c2f333f9e) · head (6f7d523f9b22) · base (851f53438f5a) · OkTest (2b1bdfd25e98)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codex-maintenance Low-risk maintenance changes created by Codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant