fix: preserve fast-format arguments - #508
Conversation
Castiron custom code✅ No new custom-code files detected. 50 mixed files remain; 0 existing customizations changed. Compared 50 existing customizations unchanged
10 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 32448082097 --repo openai/openai-ruby \
--name castiron-custom-code-32448082097-1 --dir /tmp/castiron-custom-code-32448082097-1
git apply --stat /tmp/castiron-custom-code-32448082097-1/custom-code.patch
cat /tmp/castiron-custom-code-32448082097-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 851f53438f5afc7f32e3ccbe866fd03bbade576a 6f7d523f9b22955ef5231429f036d651165ac363
python3 scripts/castiron/custom_code_report.py report \
--base 851f53438f5afc7f32e3ccbe866fd03bbade576a \
--head 6f7d523f9b22955ef5231429f036d651165ac363 --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-6f7d523f9b22
cat /tmp/castiron-custom-code-6f7d523f9b22/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Summary
Scope and compatibility
Affected paths are scripts/fast-format and test/scripts/fast_format_test.rb. The direct consumer is the developer fast-format workflow. Both files are handwritten repository artifacts, not generated output. This does not change the public SDK API, runtime transport, wire formats, dependencies, supported Ruby versions, or generated code.
Validation