test: harden mock server lifecycle checks - #507
Conversation
jbeckwith-oai
added
the
codex-maintenance
Castiron custom code✅ No new custom-code files detected. 48 mixed files remain; 0 existing customizations changed. Compared 48 existing customizations unchanged
8 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 32527425563 --repo openai/openai-ruby \
--name castiron-custom-code-32527425563-1 --dir /tmp/castiron-custom-code-32527425563-1
git apply --stat /tmp/castiron-custom-code-32527425563-1/custom-code.patch
cat /tmp/castiron-custom-code-32527425563-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 0491bb7ae7dd465c48aa1b84496b2e6d7e3597ea cc05d64deb4e51b74ea440563cad174d7b2c7801
python3 scripts/castiron/custom_code_report.py report \
--base 0491bb7ae7dd465c48aa1b84496b2e6d7e3597ea \
--head cc05d64deb4e51b74ea440563cad174d7b2c7801 --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-cc05d64deb4e
cat /tmp/castiron-custom-code-cc05d64deb4e/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
jbeckwith-oai
changed the title
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bd221ed42d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b97fc07c97
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
apcha-oai
left a comment
apcha-oai
left a comment
There was a problem hiding this comment.
[sdk codex review] Completed two independent reviews of 5dffc71. The previously reported connected-client and failed-bind cases are fixed, but two distinct P2 lifecycle cases remain: cleanup can kill an unrelated listener on another local address, and readiness-timeout failure can leave an owned mock listener running. Both have isolated base/head reproductions; no live host listener was killed. The supplied 6-test/26-assertion workflow suite and hosted checks pass but do not cover these cases. Please preserve the existing fixes while making cleanup ownership-aware. Head/base/author/draft/mergeability and feedback were rechecked; newer main changes only fast-format tooling.
5dffc71 to
81742d3
Compare
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
81742d3 to
cacf201
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cacf2012e5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
cacf201 to
a5b5239
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a5b5239208
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
a5b5239 to
8935263
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8935263309
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4332423b13
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ba23d4210f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ba23d42 to
b1bc81c
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b1bc81c581
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
2 participants
Summary
Evidence
Without
curl --fail, an HTTP error response can be mistaken for a healthy mock server.lsof -tcan also return multiple newline-delimited PIDs, and listeners can exit between discovery and cleanup.Blast radius and ownership
This changes only the handwritten local test launcher and its new workflow tests. It does not affect generated code, SDK runtime behavior, public APIs, type signatures, dependencies, serialization, transport, or release behavior.
Validation
bash -n scripts/testbundle exec ruby -w test/scripts/test_workflow_test.rb— 4 tests, 20 assertionsbundle exec rake lint— RuboCop, rubyfmt, Sorbet, RBS, and directive validation passed./scripts/test— 1,091 tests, 9,822 assertions, 0 failures, 0 errorsgit diff --check