examples: validate Responses function tool output - #505
Conversation
Castiron custom code✅ No new custom-code files detected. 48 mixed files remain; 0 existing customizations changed. Compared 48 existing customizations unchanged
8 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 32446845547 --repo openai/openai-ruby \
--name castiron-custom-code-32446845547-1 --dir /tmp/castiron-custom-code-32446845547-1
git apply --stat /tmp/castiron-custom-code-32446845547-1/custom-code.patch
cat /tmp/castiron-custom-code-32446845547-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 851f53438f5afc7f32e3ccbe866fd03bbade576a c2c1e7b9bf91ff7ae5ad63d6f236ad551922fa49
python3 scripts/castiron/custom_code_report.py report \
--base 851f53438f5afc7f32e3ccbe866fd03bbade576a \
--head c2c1e7b9bf91ff7ae5ad63d6f236ad551922fa49 --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-c2c1e7b9bf91
cat /tmp/castiron-custom-code-c2c1e7b9bf91/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
apcha-oai
left a comment
There was a problem hiding this comment.
[sdk codex review] Approved after two independent reviews of c2c1e7b. Verified mixed-output discrimination, typed GetWeather parsing, multiple valid calls, clear empty/invalid-output failure, and serial-test isolation without SDK API changes. Independent checks passed: 13 focused/helper tests with 53 assertions, five separate real-parser/example scenarios, syntax, and offline inventory. The local test run used a fallback mock dependency rather than the exact locked bundle; no live API tests were run. All current required checks pass. Latest main's tooling-only changes were reviewed, and head/base/author/draft/mergeability and feedback were rechecked before submission.
Summary
GetWeatherfunction callsScope and compatibility
The change is limited to a handwritten example and its test. It does not modify generated code, runtime SDK behavior, public APIs, type signatures, transport, authentication, serialization, dependencies, or supported Ruby versions.
Generator ownership:
examples/and this regression test are handwritten repository artifacts, so no regeneration is required.Validation
git diff --check: passed