test: characterize ambiguous union behavior - #504
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Castiron custom code✅ No new custom-code files detected. 48 mixed files remain; 0 existing customizations changed. Compared 48 existing customizations unchanged
8 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 32448634742 --repo openai/openai-ruby \
--name castiron-custom-code-32448634742-1 --dir /tmp/castiron-custom-code-32448634742-1
git apply --stat /tmp/castiron-custom-code-32448634742-1/custom-code.patch
cat /tmp/castiron-custom-code-32448634742-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 851f53438f5afc7f32e3ccbe866fd03bbade576a e4cc7dcd44f4f1e3e33338a8579fdf9648eb828d
python3 scripts/castiron/custom_code_report.py report \
--base 851f53438f5afc7f32e3ccbe866fd03bbade576a \
--head e4cc7dcd44f4f1e3e33338a8579fdf9648eb828d --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-e4cc7dcd44f4
cat /tmp/castiron-custom-code-e4cc7dcd44f4/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d90571e548
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1 participant
Summary
This PR is characterization-only. It does not change
Union,Converter,BaseModel, generated models, signatures, or public runtime behavior.What the corpus shows
EasyInputMessageandResponseInputItem::Message;type: :messageis also registered by three variants and does not uniquely identify one Ruby class.UnknownServerEventat its connection boundary even though direct shared-union coercion can still guess a known event for symbolized input.The field is deliberately named
compatibility_selected: an ambiguous or unknown selection is recorded behavior, not a claim that the class is semantically correct. Focused assertions retain the compatibility-sensitive facts; the full historical differential is generated on demand.Generator ownership
The corpus exercises real generated models without editing them. All changes are SDK-owned tests, fixtures, and developer scripts.
Validation
bundle exec rake lint: 2,730 RuboCop files, Sorbet, and 1,239 RBS files greengit diff --checkThe canonical local suite's sole failure is
RealtimeNetworkInvariantsTest#test_http_proxy_uses_connect_and_isolates_proxy_and_origin_credentials; the sandbox proxy stack closes the local CONNECT listener before acceptance. The same invariant was already reproduced unchanged on untouchedmainduring the preceding #376 work, and the other six tests in that file pass.Refs #287 and #376.