examples: validate E2E manifest mappings - #503
Conversation
jbeckwith-oai
added
the
codex-maintenance
Castiron custom code✅ No new custom-code files detected. 48 mixed files remain; 0 existing customizations changed. Compared 48 existing customizations unchanged
8 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 32446588835 --repo openai/openai-ruby \
--name castiron-custom-code-32446588835-1 --dir /tmp/castiron-custom-code-32446588835-1
git apply --stat /tmp/castiron-custom-code-32446588835-1/custom-code.patch
cat /tmp/castiron-custom-code-32446588835-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 851f53438f5afc7f32e3ccbe866fd03bbade576a b518c5c1b3ac5defbee9e0b6ead0f51c85dfeb05
python3 scripts/castiron/custom_code_report.py report \
--base 851f53438f5afc7f32e3ccbe866fd03bbade576a \
--head b518c5c1b3ac5defbee9e0b6ead0f51c85dfeb05 --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-b518c5c1b3ac
cat /tmp/castiron-custom-code-b518c5c1b3ac/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
jbeckwith-oai
changed the title
apcha-oai
left a comment
apcha-oai
left a comment
There was a problem hiding this comment.
[sdk codex review] Approved after two independent reviews of b518c5c. Root, examples-collection, and per-example mapping guards reject malformed shapes before access and preserve valid-manifest behavior, safe YAML loading, subprocess controls, and report redaction. Both reviewers independently passed the 17-test/199-assertion harness suite, additional malformed-shape CLI probes, syntax checks, and offline inventory. Local tests used available mock-library fallbacks rather than the exact locked bundle; no live APIs were used. All current required checks pass. Head/base/author/draft/mergeability and existing feedback were rechecked; no actionable findings.
2 participants
Summary
Evidence
Malformed YAML shapes currently reach hash access and fail with incidental exceptions. The focused tests cover nil, array, and string roots and per-example configurations, and assert stable
ConfigurationErrormessages.Blast radius and compatibility
This is limited to the handwritten examples E2E inventory script and its dedicated tests. It does not change the public SDK API, generated code, request transport, wire behavior, dependencies, RBI/RBS contracts, or supported Ruby versions. Valid manifests retain existing behavior.
Generator ownership
Both changed files are handwritten repository tooling and tests; no generator-owned source or output is modified.
Validation
bundle exec rake test TEST=test/scripts/examples_e2e_test.rb— 17 runs, 199 assertions, 0 failures, 0 errorsbundle exec rake lint— 2,728 Ruby files inspected with no offenses; 1,239 RBS files validated; Sorbet, rubyfmt, and directive validation passgit diff --check— cleanBecause this touches manifest deserialization validation, please include
@openai/sdks-teamin review routing.