Skip to content

chore(node): generate checkpoint permission admin auth - #2445

Open
apcha-oai wants to merge 1 commit into
mainfrom
castiron/promotions/pr-71
Open

chore(node): generate checkpoint permission admin auth#2445
apcha-oai wants to merge 1 commit into
mainfrom
castiron/promotions/pr-71

Conversation

@apcha-oai

Copy link
Copy Markdown
Contributor

Summary

Declare the existing admin-key requirement in the canonical API reference so Castiron generates the authentication selection already present in the public Node SDK. All production TypeScript sources are byte-for-byte unchanged relative to the current public baseline; there are no API, overload, dependency, or runtime behavior changes.

The hash-verified report drops 32 → 31 mixed files and 1,770 → 1,762 custom-patch lines. src/resources/fine-tuning/checkpoints/permissions.ts now exactly matches pure generation, removing its eight-line customization. The other 31 customizations are unchanged. Generation metadata was produced through the supported Castiron generation/rebase workflow.

Validation

The existing checkpoint-auth case and 12 new focused public-entrypoint cases pass, covering create, legacy retrieve, paginated list, and delete: select the admin key without resolving the project-key provider, preserve resource authentication precedence, and reject missing admin credentials without falling back to the project key. Formatting/lint and TypeScript checks pass. Broad suites are left to CI; no full local Castiron fixture/parity sweep was run.

Focused auth/compatibility review is requested. Tracked as custom-code-burndown.

Castiron-Internal-PR: openai/openai-node-internal#71
Castiron-Source-SHA: a57096a2d23ad92a6ba050a71bafbfcfe8e137c0
Castiron-Public-Base-SHA: 283e12b
@apcha-oai apcha-oai added the custom-code-burndown Behavior-preserving reductions of custom code in generated SDK files label Aug 21, 2026
@github-actions

github-actions Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Castiron custom code

✅ No new custom-code files detected.

31 mixed files remain; 0 existing customizations changed; 1 customizations removed; 1 generated baselines changed.

Compared 283e12be45fb712a16a5aeb5. Generated baselines verified.

File Result Current custom patch
src/resources/fine-tuning/checkpoints/permissions.ts Generated baseline changed None
31 existing customizations unchanged
  • api.md
  • scripts/castiron/README.md
  • scripts/castiron/custom_code_report.py
  • scripts/castiron/test_custom_code_report.py
  • src/client.ts
  • src/resources/audio/transcriptions.ts
  • src/resources/audio/translations.ts
  • src/resources/beta/assistants.ts
  • src/resources/beta/beta.ts
  • src/resources/beta/index.ts
  • src/resources/beta/responses/internal-base.ts
  • src/resources/beta/responses/responses.ts
  • src/resources/beta/threads/index.ts
  • src/resources/beta/threads/runs/index.ts
  • src/resources/beta/threads/runs/runs.ts
  • src/resources/beta/threads/threads.ts
  • src/resources/chat/completions/completions.ts
  • src/resources/chat/completions/index.ts
  • src/resources/conversations/index.ts
  • src/resources/embeddings.ts
  • src/resources/files.ts
  • src/resources/images.ts
  • src/resources/responses/internal-base.ts
  • src/resources/responses/responses.ts
  • src/resources/skills/skills.ts
  • src/resources/skills/versions/versions.ts
  • src/resources/vector-stores/file-batches.ts
  • src/resources/vector-stores/files.ts
  • src/resources/webhooks/index.ts
  • src/resources/webhooks/webhooks.ts
  • tests/lib/data-residency.test.ts

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 32491071375 --repo openai/openai-node \
  --name castiron-custom-code-32491071375-1 --dir /tmp/castiron-custom-code-32491071375-1
git apply --stat /tmp/castiron-custom-code-32491071375-1/custom-code.patch
cat /tmp/castiron-custom-code-32491071375-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin 283e12be45fbcd3a230b5c3e4651b87073d7116f 712a16a5aeb53c289ab4d8c19742c43bea6368de
python3 scripts/castiron/custom_code_report.py report \
  --base 283e12be45fbcd3a230b5c3e4651b87073d7116f \
  --head 712a16a5aeb53c289ab4d8c19742c43bea6368de --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-712a16a5aeb5
cat /tmp/castiron-custom-code-712a16a5aeb5/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

@apcha-oai
apcha-oai marked this pull request as ready for review August 21, 2026 14:14
@apcha-oai
apcha-oai requested a review from a team as a code owner August 21, 2026 14:14
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 21, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-21T14:15:43.157590Z 712a16a Draft marked ready
🔒 Security Review Completed 2026-08-21T14:16:06.636653Z 712a16a Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@openai-sdks

openai-sdks Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

OkTest Summary

237/237 SDK tests passed in 9.092s for Node SDK PR #2445.

Test results — 42 files
Test Result Time
tests/chat-completions-complex-body.test.ts ✅ Passed 116ms
tests/chat-completions-create.test.ts ✅ Passed 189ms
tests/chat-completions-stream.test.ts ✅ Passed 151ms
tests/files-content-binary.test.ts ✅ Passed 126ms
tests/files-create-multipart.test.ts ✅ Passed 209ms
tests/files-list-pagination.test.ts ✅ Passed 136ms
tests/initialize-config.test.ts ✅ Passed 115ms
tests/instance-isolation.test.ts ✅ Passed 80ms
tests/models-list.test.ts ✅ Passed 116ms
tests/responses-background-lifecycle.test.ts ✅ Passed 186ms
tests/responses-body-method-errors.test.ts ✅ Passed 263ms
tests/responses-cancel-timeout.test.ts ✅ Passed 225ms
tests/responses-cancel.test.ts ✅ Passed 205ms
tests/responses-compact-retries.test.ts ✅ Passed 226ms
tests/responses-compact.test.ts ✅ Passed 234ms
tests/responses-create-advanced-stream.test.ts ✅ Passed 108ms
tests/responses-create-advanced.test.ts ✅ Passed 176ms
tests/responses-create-disconnect.test.ts ✅ Passed 1.073s
tests/responses-create-errors.test.ts ✅ Passed 167ms
tests/responses-create-malformed-api-responses.test.ts ✅ Passed 123ms
tests/responses-create-retries.test.ts ✅ Passed 197ms
tests/responses-create-stream-failures.test.ts ✅ Passed 206ms
tests/responses-create-stream-timeout.test.ts ✅ Passed 2.152s
tests/responses-create-stream-wire.test.ts ✅ Passed 2.061s
tests/responses-create-stream.test.ts ✅ Passed 101ms
tests/responses-create-terminal-states.test.ts ✅ Passed 250ms
tests/responses-create-timeout.test.ts ✅ Passed 195ms
tests/responses-create.test.ts ✅ Passed 128ms
tests/responses-delete.test.ts ✅ Passed 126ms
tests/responses-input-items-errors.test.ts ✅ Passed 140ms
tests/responses-input-items-list.test.ts ✅ Passed 137ms
tests/responses-input-items-options.test.ts ✅ Passed 91ms
tests/responses-input-tokens-count-timeout.test.ts ✅ Passed 217ms
tests/responses-input-tokens-count.test.ts ✅ Passed 178ms
tests/responses-malformed-inputs.test.ts ✅ Passed 1.744s
tests/responses-not-found-errors.test.ts ✅ Passed 202ms
tests/responses-parse.test.ts ✅ Passed 149ms
tests/responses-retrieve-retries.test.ts ✅ Passed 215ms
tests/responses-retrieve.test.ts ✅ Passed 184ms
tests/responses-stored-method-errors.test.ts ✅ Passed 553ms
tests/retry-behavior.test.ts ✅ Passed 2.921s
tests/sdk-error-shape.test.ts ✅ Passed 215ms

View OkTest run #32491073672

SDK merge (65baf5d73e1f) · head (712a16a5aeb5) · base (283e12be45fb) · OkTest (2b1bdfd25e98)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

custom-code-burndown Behavior-preserving reductions of custom code in generated SDK files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant