chore(node): generate checkpoint permission admin auth - #2445
Conversation
Castiron-Internal-PR: openai/openai-node-internal#71 Castiron-Source-SHA: a57096a2d23ad92a6ba050a71bafbfcfe8e137c0 Castiron-Public-Base-SHA: 283e12b
Castiron custom code✅ No new custom-code files detected. 31 mixed files remain; 0 existing customizations changed; 1 customizations removed; 1 generated baselines changed. Compared
31 existing customizations unchanged
A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 32491071375 --repo openai/openai-node \
--name castiron-custom-code-32491071375-1 --dir /tmp/castiron-custom-code-32491071375-1
git apply --stat /tmp/castiron-custom-code-32491071375-1/custom-code.patch
cat /tmp/castiron-custom-code-32491071375-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 283e12be45fbcd3a230b5c3e4651b87073d7116f 712a16a5aeb53c289ab4d8c19742c43bea6368de
python3 scripts/castiron/custom_code_report.py report \
--base 283e12be45fbcd3a230b5c3e4651b87073d7116f \
--head 712a16a5aeb53c289ab4d8c19742c43bea6368de --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-712a16a5aeb5
cat /tmp/castiron-custom-code-712a16a5aeb5/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Summary
Declare the existing admin-key requirement in the canonical API reference so Castiron generates the authentication selection already present in the public Node SDK. All production TypeScript sources are byte-for-byte unchanged relative to the current public baseline; there are no API, overload, dependency, or runtime behavior changes.
The hash-verified report drops 32 → 31 mixed files and 1,770 → 1,762 custom-patch lines.
src/resources/fine-tuning/checkpoints/permissions.tsnow exactly matches pure generation, removing its eight-line customization. The other 31 customizations are unchanged. Generation metadata was produced through the supported Castiron generation/rebase workflow.Validation
The existing checkpoint-auth case and 12 new focused public-entrypoint cases pass, covering
create, legacyretrieve, paginatedlist, anddelete: select the admin key without resolving the project-key provider, preserve resource authentication precedence, and reject missing admin credentials without falling back to the project key. Formatting/lint and TypeScript checks pass. Broad suites are left to CI; no full local Castiron fixture/parity sweep was run.Focused auth/compatibility review is requested. Tracked as
custom-code-burndown.