fix: avoid double-counting logprobs in streamed chat completions - #2444
Open
dfedoryshchev wants to merge 1 commit into
Open
fix: avoid double-counting logprobs in streamed chat completions#2444dfedoryshchev wants to merge 1 commit into
dfedoryshchev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes being requested
#accumulateChatCompletionseeds a new choice with the chunk'slogprobsby reference, so on that same iterationchoice.logprobs === logprobsandchoice.logprobs.content.push(...content)pushes the array into itself. One streamed token arrives as two entries infinalChatCompletion().choices[0].logprobs.contentand in thelogprobs.content.donepayload.The initialise branch then does
choice.logprobs = { ...logprobs }, one level deep, so the snapshot keeps the caller's array and the next chunk'spushappends into the chunk the caller passed in.Current tests miss both: the fixture's first logprobs-bearing chunk is
{"content":[],"refusal":null}, sopush(...[])is a no-op, and nothing streams two chunks that each carry logprobs.Fix: seed
logprobs: null, and copy the arrays when initialising.Additional context & links
main.npx vitest run --config vitest.config.mts tests/lib/ChatCompletionStream.test.ts-> 38 passed.oxlintandoxfmt --checkpass.