fix(zod): support zod v4 mini schemas#1985
Open
morgan-coded wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes being requested
zod/v4-minischemas did not type-check with the structured-output helpers because they only accepted Zod v3 and regular Zod v4 schema types. This widens those helpers to accept mini schemas, keeps the existing v3/v4 JSON Schema conversion paths, and uses one parser path for response, text, and tool arguments. I checked the new mini coverage failing under TypeScript before the helper change, then ran./scripts/bootstrap,./scripts/test tests/helpers/zod.test.ts,./node_modules/typescript/bin/tsc,pnpm build,pnpm lint, andpnpm testwith 1145 passing and 1 skipped. Fixes #1564Additional context & links