fix streaming accept header#1978
Open
sarptandoven wants to merge 1 commit into
Open
Conversation
Use text/event-stream as the default Accept header when request options enable streaming while preserving explicit Accept overrides. Add regression coverage for streaming, non-streaming, and override cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
Acceptheader totext/event-streamwhen request options enable streamingapplication/jsonfor non-streaming requestsAcceptheaders for custom streaming transportswhy
text/event-stream, and some OpenAI-compatible gateways validate the requestAcceptheader before returning an SSE responsevalidation
pnpm exec jest tests/index.test.ts -t 'accept header' --runInBandpnpm exec jest tests/index.test.ts --runInBandpnpm exec tsc --noEmit --pretty falsegit diff --checkpnpm lintpnpm test