ci: declare contents:read on detect-breaking-changes workflow#1876
Open
arpitjain099 wants to merge 1 commit into
Open
ci: declare contents:read on detect-breaking-changes workflow#1876arpitjain099 wants to merge 1 commit into
arpitjain099 wants to merge 1 commit into
Conversation
The detect_breaking_changes and agents_sdk jobs run scripts against the PR diff and PR base; no GitHub API write beyond actions/checkout. contents:read is the floor. Style matches the per-job permissions blocks already declared by ci.yml, publish-jsr.yml, publish-npm.yml (contents:read + id-token:write for trusted npm publishing). Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
nomiveritas
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
detect-breaking-changes.ymlworkflow has two jobs (detect_breaking_changes,agents_sdk) that run scripts against the PR diff and base. Neither writes to the repo or comments on the PR -- they fail the build if a breaking change is detected.This patch pins the workflow to
permissions: contents: read. The style matches the per-job permission blocks already declared byci.yml,publish-jsr.yml, andpublish-npm.yml(typicallycontents: read+id-token: writefor trusted publishing).With explicit scope:
Token-Permissionscheck passes for this fileactions/setup-node@v3,pnpm/action-setup@v4) is bounded to readNo behavioural change.