fix: validate function tool concurrency type - #4573
Closed
hsusul wants to merge 1 commit into
Closed
Conversation
Member
|
Thanks for the contribution. max_function_tool_concurrency is publicly typed and documented as int | None; a fractional value already violates that contract, and the current behavior for True requires relying on Python's bool subclassing plus an intentionally unusual runtime value. The tests establish constructibility, but not a supported producer, ordinary configuration path, or meaningful user impact. I am going to close this PR because the additional runtime type contract is not justified by the demonstrated need. We can revisit fail-fast validation if a supported untyped configuration boundary is shown to produce these values in ordinary use. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
max_function_tool_concurrencyvalues when constructingToolExecutionConfigNone, positive integers, and integers below oneTruefrom acting as a limit of oneTest plan
.agents/skills/code-change-verification/scripts/run.sh/reviewFocused validation:
uv run pytest tests/test_run_config.py -q(44 passed)uv run pytest tests/test_run_step_execution.py -q -k function_tool_concurrency(3 passed, 105 deselected)4 passed, 40 deselected)The separate parallel
make testsrun completed with8954 passed, 28 skipped, 38 failed; all failures require local socket binding, multiprocessing, or native macOS sandbox execution, which this environment blocks. None touched the changed configuration tests or execution path.Issue number
N/A
Checks